Mock implementation part 2 #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
CalvinNeo
commented
Oct 30, 2021
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
solotzg
reviewed
Nov 2, 2021
mock-engine-store/src/lib.rs
Outdated
Comment on lines
737
to
741
| if snaps.len > 0 { | ||
| ffi_interfaces::EngineStoreApplyRes::Persist | ||
| } else { | ||
| ffi_interfaces::EngineStoreApplyRes::None | ||
| } |
There was a problem hiding this comment.
Can we reutrn Persist directly ?
There was a problem hiding this comment.
I find in tiflash, apply state persistence can be skipped, when the snapshot is empty. So I think I should also mock this behavior.
There was a problem hiding this comment.
Before pingcap/tiflash#1811, BR/Lightning may let ingest sst cmd contain only one CF. It may cause that tiflash can not flush all region cache into column storage and region->dataSize() will be bigger than 0. After write&default cf sst ingested, tiflash can flush all and region->dataSize() will be 0.
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is not included in this PR:
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tidb-ansible:Check List
Tests
Side effects
Release note