Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore with BR or import data with TiDB-lightning may throw error #1811

Closed
leiysky opened this issue Apr 22, 2021 · 5 comments
Closed

Restore with BR or import data with TiDB-lightning may throw error #1811

leiysky opened this issue Apr 22, 2021 · 5 comments
Assignees
Labels
severity/minor type/bug The issue is confirmed as a bug.

Comments

@leiysky
Copy link
Contributor

leiysky commented Apr 22, 2021

Sometimes TiFlash will throw error when handling IngestSST raft command. The root cause is BR or lightning may lead to incorrect SST data, but we currently doesn't have way to reproduce this.

This issue is for tracking.

image

@leiysky leiysky added type/bug The issue is confirmed as a bug. severity/minor labels Apr 22, 2021
@leiysky
Copy link
Contributor Author

leiysky commented Apr 22, 2021

/cc @solotzg

@solotzg
Copy link
Contributor

solotzg commented Apr 23, 2021

Approximate logs in tiflash are like:

2021/4/22 17:33:55.044 region 37227 begin to ingest default cf at [term 7, index 11][thread 15]
2021/4/22 17:33:55.232 region 37227 ingest default cf kv count 51612 [thread 15]

2021/4/22 17:33:55.241 region 37227 begin to ingest default cf at [term 7, index 12][thread 15]
2021/4/22 17:33:55.252 region 37227 meet exception: found existing key in hex: .....

Lighting/BR ingested default cf into one region twice(because tikv server is down once), and tiflash thrown exception because found existing key. This behavior is legal in kv storage, but for tiflash, we can write date into storage layer only when there are matched data in default & write cf.

@solotzg solotzg self-assigned this Apr 23, 2021
@solotzg
Copy link
Contributor

solotzg commented Apr 27, 2021

@solotzg
Copy link
Contributor

solotzg commented May 20, 2021

It shall be fixed by pingcap/br#1089

@solotzg solotzg closed this as completed May 27, 2021
@solotzg
Copy link
Contributor

solotzg commented May 28, 2021

release-5.0
pingcap/br#1150
tikv/tikv#10202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

2 participants