Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

lightning/restore: support ingset multi ssts for same range (#1089) #1150

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1089

What problem does this PR solve?

Ingest multi SST files (different CF) together to gain better consistency. This can resolve the problem that lighting import or BR restore may cause TiFlash panic.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has interface methods change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • No Release Note

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-1089-to-release-5.0 branch from 0c65ec9 to fd12d0a Compare May 27, 2021 05:10
@glorv glorv added this to the v5.0.2 milestone May 27, 2021
@glorv glorv force-pushed the cherry-pick-1089-to-release-5.0 branch from ec92e04 to d14f184 Compare May 27, 2021 06:01
@glorv glorv force-pushed the cherry-pick-1089-to-release-5.0 branch from 92d4e54 to 72e1687 Compare May 27, 2021 08:47
Copy link
Collaborator

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label May 28, 2021
@glorv
Copy link
Collaborator

glorv commented May 28, 2021

/run-all-tests

@glorv
Copy link
Collaborator

glorv commented May 28, 2021

/run-all-tests

@3pointer
Copy link
Collaborator

/lgtm

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • Little-Wallace

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels May 28, 2021
@glorv
Copy link
Collaborator

glorv commented May 28, 2021

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 23a2749

@ti-chi-bot ti-chi-bot merged commit e81f002 into pingcap:release-5.0 May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants