lightning/restore: support ingset multi ssts for same range #1089
Conversation
glorv
force-pushed
the
ingest-multi-cf
branch
3 times, most recently
from
5e5d384 to
449398d
Compare
|
/build |
ti-chi-bot
added
needs-rebase
and removed
do-not-merge/work-in-progress
| if err != nil { | ||
| if s, ok := status.FromError(err); ok { | ||
| if s.Code() == codes.Unimplemented { | ||
| local.supportMultiIngest = false |
There was a problem hiding this comment.
Does tiflash need to implement such interfaces? @Little-Wallace
There was a problem hiding this comment.
It seems that supportMultiIngest is true only when all stores have implemented related interfaces.
There was a problem hiding this comment.
MultiIngest is only called by region leader, so tiflash needn't implement this interface. We should skip check tiflash here
pkg/restore/client.go
Outdated
| idx++ | ||
| } | ||
|
|
||
| return files[idx:], files[idx:] |
There was a problem hiding this comment.
files[:idx], files[idx:] 🤔️？
|
/lgtm |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created: #1149. |
|
In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/br#release-4.0 from head ti-chi-bot:cherry-pick-1089-to-release-4.0: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-1089-to-release-4.0."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created: #1150. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/br#release-5.0 from head ti-chi-bot:cherry-pick-1089-to-release-5.0: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-1089-to-release-5.0."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} |
backup/checksum: add cluster index support for ranges (pingcap#1120) lightning/restore: support ingset multi ssts for same range (pingcap#1089) * ingest ssts for the same range in a batch * make ingest compatible with old tikv tests: add row count check for br clustered index tests (pingcap#1151) storage: mkdirAll for local storage even when SkipCheckPath is true (pingcap#1156) tests/br: fix bug in issue pingcap#1158 (pingcap#1160) tests/br/compatibility: fix failed for manifest unknown (pingcap#1161) *: upgrade go version from 1.13/1.15 to 1.16 (pingcap#1159) action trigger: fix compatibility trigger bug on push (pingcap#1170) address comment fix test address comment address comment fix build add ut for ignore columns go.mod: update tidb to the new version (pingcap#1153) lightning: support restore data into tables that contains data (pingcap#784) fix conflict after merge master
…1089) * ingest ssts for the same range in a batch * make ingest compatible with old tikv * fix lint * fix meta length check * update tidb * do not check tiflash * add log * fix * fix * fix * fix
What problem does this PR solve?
Ingest multi SST files (different CF) together to gain better consistency. This can resolve the problem that lighting import or BR restore may cause TiFlash panic.
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release Note