Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

tests: add row count check for br clustered index tests #1151

Merged
merged 4 commits into from
May 27, 2021
Merged

tests: add row count check for br clustered index tests #1151

merged 4 commits into from
May 27, 2021

Conversation

Leavrth
Copy link
Collaborator

@Leavrth Leavrth commented May 27, 2021

What problem does this PR solve?

Key range in backup and checksum might be wrong at the same time(They are still the same) when the table use clustered index, which means checksum cannot find this error.

What is changed and how it works?

add row_count check for the test.

Check List

  • Need to cherry-pick to the release branch

Release note

-No release note

Leavrth added 2 commits May 27, 2021 15:24
Signed-off-by: Leavrth <Legenull@gmail.com>
Signed-off-by: Leavrth <Legenull@gmail.com>
Copy link
Collaborator

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label May 27, 2021
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • lonng

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels May 27, 2021
@lonng
Copy link
Contributor

lonng commented May 27, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d1954bc

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1154.

@Leavrth Leavrth removed this from the v5.0.2 milestone May 27, 2021
3pointer added a commit to 3pointer/br that referenced this pull request Jun 4, 2021
backup/checksum: add cluster index support for ranges (pingcap#1120)

lightning/restore: support ingset multi ssts for same range (pingcap#1089)

* ingest ssts for the same range in a batch

* make ingest compatible with old tikv

tests: add row count check for br clustered index tests (pingcap#1151)

storage: mkdirAll for local storage even when SkipCheckPath is true (pingcap#1156)

tests/br: fix bug in issue pingcap#1158 (pingcap#1160)

tests/br/compatibility: fix failed for manifest unknown (pingcap#1161)

*: upgrade go version from 1.13/1.15 to 1.16 (pingcap#1159)

action trigger: fix compatibility trigger bug on push (pingcap#1170)

address comment

fix test

address comment

address comment

fix build

add ut for ignore columns

go.mod: update tidb to the new version (pingcap#1153)

lightning: support restore data into tables that contains data (pingcap#784)

fix conflict after merge master
@Leavrth Leavrth deleted the br_clustered_index_tests branch June 11, 2021 04:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants