Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

backup/checksum: add cluster index support for ranges #1120

Merged
merged 11 commits into from
May 26, 2021
Merged

backup/checksum: add cluster index support for ranges #1120

merged 11 commits into from
May 26, 2021

Conversation

Leavrth
Copy link
Collaborator

@Leavrth Leavrth commented May 19, 2021 •
edited
Loading

What problem does this PR solve?

ranges only support single integer primary key.

What is changed and how it works?

Let ranges be NotNullRange if table use the common handle

Check List

Tests

  • Unit test
  • Integration test
  • Manual test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Related changes

  • Need to cherry-pick to the release branch

Release note

  • No release note

Jianjun Liao added 2 commits May 18, 2021 19:19
@Leavrth
add cluster index support for ranges
ef8d0d6 
Signed-off-by: Leavrth <Legenull@gmail.com>
@Leavrth
add clustered index support for ranges
e6af1f7 
Signed-off-by: Leavrth <Legenull@gmail.com>
@CLAassistant
Copy link

CLAassistant commented May 19, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot
Copy link
Member

Welcome @Leavrth!

It looks like this is your first PR to pingcap/br 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/br. 😃

@ti-chi-bot ti-chi-bot requested review from 3pointer and overvenus May 19, 2021 08:09
@ti-chi-bot ti-chi-bot added size/L and removed size/S labels May 20, 2021
@3pointer
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label May 20, 2021
Little-Wallace
Little-Wallace approved these changes May 20, 2021
View reviewed changes
Copy link
Collaborator

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • Little-Wallace

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels May 20, 2021
@3pointer
Copy link
Collaborator

/run-all-tests

@Leavrth
Copy link
Collaborator Author

Leavrth commented May 21, 2021

/assign @3pointer

@Leavrth
Copy link
Collaborator Author

Leavrth commented May 22, 2021

/run-all-tests

1 similar comment
@3pointer
Copy link
Collaborator

/run-all-tests

@Leavrth
fix format
b9deb61 
Signed-off-by: Leavrth <Legenull@gmail.com>
@Leavrth
Copy link
Collaborator Author

Leavrth commented May 24, 2021

/run-all-tests

@Leavrth
Copy link
Collaborator Author

Leavrth commented May 24, 2021

/run-integration-test

@Leavrth
Copy link
Collaborator Author

Leavrth commented May 24, 2021

/merge

@ti-chi-bot
Copy link
Member

@Leavrth: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@3pointer
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b9deb61

@3pointer
Copy link
Collaborator

/run-all-tests

@Leavrth
Copy link
Collaborator Author

Leavrth commented May 26, 2021

/run-build

@Leavrth
Copy link
Collaborator Author

Leavrth commented May 26, 2021

/rebuild

@Leavrth
Copy link
Collaborator Author

Leavrth commented May 26, 2021

/run-all-tests

@zhouqiang-cl
Copy link
Contributor

/rebuild

@Leavrth
Copy link
Collaborator Author

Leavrth commented May 26, 2021

/run-integration-tests

1 similar comment
@ZipFast
Copy link
Contributor

ZipFast commented May 26, 2021

/run-integration-tests

@ZipFast
Copy link
Contributor

ZipFast commented May 26, 2021

/rebuild

@3pointer
Copy link
Collaborator

/run-integration-tests

@ti-chi-bot ti-chi-bot merged commit d5f5f9d into pingcap:master May 26, 2021
ti-chi-bot pushed a commit to ti-chi-bot/br that referenced this pull request May 26, 2021
@Leavrth @ti-chi-bot
backup/checksum: add cluster index support for ranges (pingcap#1120)
7ccba42
@ti-chi-bot ti-chi-bot mentioned this pull request May 26, 2021
Merged
3 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1145.

ti-chi-bot added a commit that referenced this pull request May 27, 2021
@ti-chi-bot
backup/checksum: add cluster index support for ranges (#1120) (#1145)
e8fab68
3pointer added a commit to 3pointer/br that referenced this pull request Jun 4, 2021
@3pointer
fix default-columns ci
9feee1b 
backup/checksum: add cluster index support for ranges (pingcap#1120)

lightning/restore: support ingset multi ssts for same range (pingcap#1089)

* ingest ssts for the same range in a batch

* make ingest compatible with old tikv

tests: add row count check for br clustered index tests (pingcap#1151)

storage: mkdirAll for local storage even when SkipCheckPath is true (pingcap#1156)

tests/br: fix bug in issue pingcap#1158 (pingcap#1160)

tests/br/compatibility: fix failed for manifest unknown (pingcap#1161)

*: upgrade go version from 1.13/1.15 to 1.16 (pingcap#1159)

action trigger: fix compatibility trigger bug on push (pingcap#1170)

address comment

fix test

address comment

address comment

fix build

add ut for ignore columns

go.mod: update tidb to the new version (pingcap#1153)

lightning: support restore data into tables that contains data (pingcap#784)

fix conflict after merge master
3pointer pushed a commit to 3pointer/br that referenced this pull request Jun 4, 2021
@Leavrth @3pointer
backup/checksum: add cluster index support for ranges (pingcap#1120)
5153957
@Leavrth Leavrth deleted the common_handle branch June 11, 2021 04:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@3pointer 3pointer 3pointer left review comments

@Little-Wallace Little-Wallace Little-Wallace approved these changes

@overvenus overvenus Awaiting requested review from overvenus

Assignees

@3pointer 3pointer

Labels
contribution first-time-contributor needs-cherry-pick-release-5.0 size/L status/can-merge status/LGT2 LGTM2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Leavrth @CLAassistant @ti-chi-bot @3pointer @zhouqiang-cl @ZipFast @Little-Wallace