Fix drainer misconfiguration (#939)

pingcap · Sep 24, 2019 · 82d00f4 · 82d00f4
1 parent 761daab
commit 82d00f4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/charts/tidb-cluster/values.yaml b/charts/tidb-cluster/values.yaml
@@ -570,8 +570,9 @@ binlog:
     # just follow the format in the file and configure in the 'config' section
     # as below if you want to customize any configuration.
     # config: |
-    #   worker-count = 16
     #   detect-interval = 10
+    #   [syncer]
+    #   worker-count = 16
     #   disable-dispatch = false
     #   ignore-schemas = "INFORMATION_SCHEMA,PERFORMANCE_SCHEMA,mysql"
     #   safe-mode = false

diff --git a/tests/actions.go b/tests/actions.go
@@ -2385,10 +2385,12 @@ func (oa *operatorActions) DeployIncrementalBackup(from *TidbClusterConfig, to *
 			sets["binlog.drainer.ignoreSchemas"] = ""
 		} else {
 			from.drainerConfig = []string{
-				"worker-count = 16",
-				"detect-interval = 10",
-				"disable-dispatch = false",
-				`ignore-schemas = ""`,
+				`detect-interval = 10`,
+				`compressor = ""`,
+				`[syncer]`,
+				`worker-count = 16`,
+				`disable-dispatch = false`,
+				`ignore-schemas = "INFORMATION_SCHEMA,PERFORMANCE_SCHEMA,mysql"`,
 				`safe-mode = false`,
 				`txn-batch = 20`,
 				`db-type = "mysql"`,