Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix drainer misconfiguration #939

Merged
merged 2 commits into from
Sep 24, 2019
Merged

Fix drainer misconfiguration #939

merged 2 commits into from
Sep 24, 2019

Conversation

weekface
Copy link
Contributor

@weekface weekface commented Sep 23, 2019 •
edited
Loading

What problem does this PR solve?

from:

    # config: |
    #   worker-count = 16
    #   detect-interval = 10
    #   disable-dispatch = false
    ...

to:

    # config: |
    #   detect-interval = 10
    #   [syncer]
    #   worker-count = 16
    #   disable-dispatch = false
    ...

What is changed and how does it work?

Check List

Tests

  • E2E test
  • Stability test

Code changes

  • Has Helm charts change
  • Has Go code change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

fix drainer misconfiguration

@weekface
Copy link
Contributor Author

/run-e2e-in-kind

aylei
aylei approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tennix
tennix approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface
Copy link
Contributor Author

/run-e2e-in-kind

1 similar comment
@weekface
Copy link
Contributor Author

/run-e2e-in-kind

@weekface weekface merged commit 82d00f4 into pingcap:master Sep 24, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 24, 2019

cherry pick to release-1.0 failed

@weekface weekface mentioned this pull request Sep 24, 2019
Merged
weekface added a commit that referenced this pull request Sep 24, 2019
@weekface
Automated cherry pick of #939: fix drainer misconfiguration (#945)
7a6e09d
yahonda pushed a commit that referenced this pull request Dec 27, 2021
@dragonly
en, zh: bump TiDB Operator charts version to v1.1.8 (#939)
bfa0397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tennix tennix tennix approved these changes

@aylei aylei aylei approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drainer failed to start: contained unknown configuration options
4 participants
@weekface @sre-bot @tennix @aylei