Skip to content

Commit

Permalink
chart: do not deploy tidb-scheduler by default (#5458)
Browse files Browse the repository at this point in the history
  • Loading branch information
csuzhangxc committed Dec 14, 2023
1 parent 7cb46a1 commit b061322
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion charts/tidb-operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ controllerManager:
# kubeClientBurst: 10

scheduler:
create: true
create: false
# With rbac.create=false, the user is responsible for creating this account
# With rbac.create=true, this service account will be created
# Also see rbac.create and clusterScoped
Expand Down
8 changes: 4 additions & 4 deletions tests/pkg/fixture/fixture.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ func GetTidbCluster(ns, name, version string) *v1alpha1.TidbCluster {
Helper: &v1alpha1.HelperSpec{
Image: pointer.StringPtr(utilimage.HelperImage),
},
SchedulerName: "tidb-scheduler",
Timezone: "Asia/Shanghai",
// SchedulerName: "tidb-scheduler", // use the default k8s scheduler now
Timezone: "Asia/Shanghai",
Labels: map[string]string{
ClusterCustomKey: "value",
},
Expand Down Expand Up @@ -204,8 +204,8 @@ func GetDMCluster(ns, name, version string) *v1alpha1.DMCluster {
Version: version,
ImagePullPolicy: corev1.PullIfNotPresent,
PVReclaimPolicy: &deletePVP,
SchedulerName: "tidb-scheduler",
Timezone: "Asia/Shanghai",
// SchedulerName: "tidb-scheduler",
Timezone: "Asia/Shanghai",
Labels: map[string]string{
ClusterCustomKey: "value",
},
Expand Down

0 comments on commit b061322

Please sign in to comment.