chart: do not deploy tidb-scheduler by default #5458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5458 +/- ##
===========================================
- Coverage 61.42% 47.52% -13.91%
===========================================
Files 230 214 -16
Lines 29152 29000 -152
===========================================
- Hits 17908 13783 -4125
- Misses 9483 13586 +4103
+ Partials 1761 1631 -130
|
|
/run-pull-e2e-kind |
1 similar comment
|
/run-pull-e2e-kind |
z2665
approved these changes
Dec 14, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: z2665 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
for k8s > v1.19, we often don't need to deploy tidb-scheduler. ref https://docs.pingcap.com/tidb-in-kubernetes/stable/tidb-scheduler
and some users became confused when deploying tidb-scheduler (e.g #5462), so we disable it by default from v1.6.
What is changed and how does it work?
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.