Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default affinity for tidb if bin-log enabled #1234

Closed
Yisaer opened this issue Nov 26, 2019 · 4 comments
Closed

Add default affinity for tidb if bin-log enabled #1234

Yisaer opened this issue Nov 26, 2019 · 4 comments
Assignees

Comments

@Yisaer
Copy link
Contributor

Yisaer commented Nov 26, 2019

Feature Request

Is your feature request related to a problem? Please describe:

pingcap/docs-cn#2073

tidb is recomended to deploy into the same node with pump. Currently the affinity in our helm chart values for tidb is empty. I think it's better to set affnitiy for tidb to stay in the node with pump by default if bin-log enabled.

Teachability, Documentation, Adoption, Migration Strategy:

https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#affinity-and-anti-affinity

@Yisaer Yisaer self-assigned this Nov 26, 2019
@tennix
Copy link
Member

tennix commented Nov 26, 2019

The affinity should be set on TiDB instead of Pump. If binlog is enabled, the tidb-server should be scheduled on a node that has pump pod.

@Yisaer Yisaer changed the title Add default affinity for pump Add default affinity for tidb if bin-log enabled Nov 26, 2019
@Yisaer
Copy link
Contributor Author

Yisaer commented Nov 26, 2019

The affinity should be set on TiDB instead of Pump. If binlog is enabled, the tidb-server should be scheduled on a node that has pump pod.

Updated.

@tennix
Copy link
Member

tennix commented Nov 26, 2019

I don't think we should set it in values.yaml. This logic is complicated in helm. Instead we should add documentation for this.

@Yisaer
Copy link
Contributor Author

Yisaer commented Nov 26, 2019

Maybe we could recommend the affinity both in the document and the note in the values.yaml if the user want to enable the binlog? @tennix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants