-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default affinity for tidb if bin-log enabled #1234
Comments
The affinity should be set on TiDB instead of Pump. If binlog is enabled, the tidb-server should be scheduled on a node that has pump pod. |
Updated. |
I don't think we should set it in values.yaml. This logic is complicated in helm. Instead we should add documentation for this. |
Maybe we could recommend the affinity both in the document and the note in the |
Feature Request
Is your feature request related to a problem? Please describe:
pingcap/docs-cn#2073
tidb is recomended to deploy into the same node with pump. Currently the affinity in our helm chart values for tidb is empty. I think it's better to set affnitiy for tidb to stay in the node with pump by default if bin-log enabled.
Teachability, Documentation, Adoption, Migration Strategy:
https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#affinity-and-anti-affinity
The text was updated successfully, but these errors were encountered: