Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommended affinity setting for tidb and pump in note #1251

Merged
merged 6 commits into from
Dec 2, 2019

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Nov 28, 2019

What problem does this PR solve?

#1234
Add recommended affinity setting for tidb and pump in note for enabling binlog.

@Yisaer
Copy link
Contributor Author

Yisaer commented Nov 28, 2019

/run-e2e-in-kind

@Yisaer
Copy link
Contributor Author

Yisaer commented Nov 28, 2019

/run-e2e-in-kind

1 similar comment
@Yisaer
Copy link
Contributor Author

Yisaer commented Nov 29, 2019

/run-e2e-in-kind

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yisaer
Copy link
Contributor Author

Yisaer commented Nov 29, 2019

/run-e2e-in-kind

@Yisaer
Copy link
Contributor Author

Yisaer commented Dec 2, 2019

/run-e2e-in-kind

@Yisaer
Copy link
Contributor Author

Yisaer commented Dec 2, 2019

/run-e2e-in-kind

1 similar comment
@cofyc
Copy link
Contributor

cofyc commented Dec 2, 2019

/run-e2e-in-kind

@cofyc cofyc merged commit 0739d95 into pingcap:master Dec 2, 2019
@Yisaer Yisaer deleted the add_affinity_note_values.yaml branch February 26, 2020 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants