Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manually cherry picked affinity for tidb and pump #1278

Merged
merged 2 commits into from
Dec 4, 2019
Merged

manually cherry picked affinity for tidb and pump #1278

merged 2 commits into from
Dec 4, 2019

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Dec 4, 2019

cherry-picked by #1251

@Yisaer Yisaer requested a review from weekface December 4, 2019 03:43
@Yisaer
Copy link
Contributor Author

Yisaer commented Dec 4, 2019

/run-e2e-in-kind

weekface
weekface reviewed Dec 4, 2019
View reviewed changes
Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

charts/tidb-cluster/values.yaml Outdated Show resolved Hide resolved
@Yisaer @weekface
Update charts/tidb-cluster/values.yaml
b7f5ade 
Co-Authored-By: weekface <weekface@gmail.com>
@Yisaer Yisaer requested a review from weekface December 4, 2019 03:51
weekface
weekface approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tennix
tennix approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yisaer
Copy link
Contributor Author

Yisaer commented Dec 4, 2019

/run-e2e-in-kind

@Yisaer Yisaer merged commit 7bdfbbc into pingcap:release-1.0 Dec 4, 2019
@DanielZhangQD
Copy link
Contributor

This does not match with docs pingcap/docs-cn#2083

@Yisaer Yisaer deleted the manully_cherry_pick_affinity_for_tidb_and_pump branch February 26, 2020 04:47
yahonda pushed a commit that referenced this pull request Dec 27, 2021
@qiancai
en, zh: Update the docs to fix two broken links (#1278)
3b8bdf0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tennix tennix tennix approved these changes

@weekface weekface weekface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yisaer @DanielZhangQD @weekface @tennix