Remain PVC when TidbMonitor get deleted. #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yisaer
requested review from
aylei,
DanielZhangQD,
weekface and
cofyc
and removed request for
aylei
|
why not set |
We would keep the same strategy in PV/PVC between TidbMonitor and TidbCluster:
|
cofyc
approved these changes
May 6, 2020
-> describe what's changed. |
|
cherry pick to release-1.1 in PR #2386 |
sre-bot
added a commit
that referenced
this pull request
May 7, 2020
cofyc
added a commit
to cofyc/tidb-operator
that referenced
this pull request
May 15, 2020
cofyc
added a commit
to cofyc/tidb-operator
that referenced
this pull request
May 15, 2020
cofyc
added a commit
that referenced
this pull request
May 15, 2020
sre-bot
pushed a commit
to sre-bot/tidb-operator
that referenced
this pull request
May 15, 2020
* release v1.1.0-rc.4 * Apply suggestions from code review Co-authored-by: Ran <huangran@pingcap.com> * update release notes for pingcap#2374 * update release notes for pingcap#2374 Co-authored-by: Ran <huangran@pingcap.com>
cofyc
added a commit
that referenced
this pull request
May 15, 2020
* release v1.1.0-rc.4 * Apply suggestions from code review Co-authored-by: Ran <huangran@pingcap.com> * update release notes for #2374 * update release notes for #2374 Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: Yecheng Fu <fuyecheng@pingcap.com> Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #2329
What is changed and how does it work?
Currently we would delete pvc when tidbmonitor is deleted. In this request, we would remain PVC if TidbMonitor is deleted.
Check List
Tests
Related changes
Does this PR introduce a user-facing change?: