release v1.1.0-rc.4 #2475
Merged
release v1.1.0-rc.4 #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yisaer
previously approved these changes
May 15, 2020
ran-huang
reviewed
May 15, 2020
CHANGELOG-1.1.md
Outdated
| - Update `TiDBConfig` and `TiKVConfig` to support `4.0.0-rc` version ([#2322](https://github.com/pingcap/tidb-operator/pull/2322), [@Yisaer](https://github.com/Yisaer)) | ||
| - Fix the bug when `TidbCluster` service type is `NodePort`, the value of `NodePort` would change frequently ([#2284](https://github.com/pingcap/tidb-operator/pull/2284), [@Yisaer](https://github.com/Yisaer)) | ||
| - Add external strategy ability for `TidbClusterAutoScaler` ([#2279](https://github.com/pingcap/tidb-operator/pull/2279), [@Yisaer](https://github.com/Yisaer)) | ||
| - Don't set owner references to keep `PVC` for `TidbMonitor` when it gets deleted ([#2374](https://github.com/pingcap/tidb-operator/pull/2374), [@Yisaer](https://github.com/Yisaer)) |
There was a problem hiding this comment.
The release note should be a descriptive sentence, not a demand.
There was a problem hiding this comment.
PVC will not be deleted when `TidbMonitor` gets deleted
how about this?
Don't set owner references is the implementation details and can be skipped
Co-authored-by: Ran <huangran@pingcap.com>
| - PVC will not be deleted when `TidbMonitor` gets deleted ([#2374](https://github.com/pingcap/tidb-operator/pull/2374), [@Yisaer](https://github.com/Yisaer)) | ||
| - Support scaling for TiFlash ([#2237](https://github.com/pingcap/tidb-operator/pull/2237), [@DanielZhangQD](https://github.com/DanielZhangQD)) | ||
|
|
||
|
|
There was a problem hiding this comment.
The issue in L37 should be #2263
|
@ran-huang @DanielZhangQD |
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb-operator
that referenced
this pull request
May 15, 2020
* release v1.1.0-rc.4 * Apply suggestions from code review Co-authored-by: Ran <huangran@pingcap.com> * update release notes for pingcap#2374 * update release notes for pingcap#2374 Co-authored-by: Ran <huangran@pingcap.com>
|
cherry pick to release-1.1 in PR #2479 |
cofyc
added a commit
that referenced
this pull request
May 15, 2020
* release v1.1.0-rc.4 * Apply suggestions from code review Co-authored-by: Ran <huangran@pingcap.com> * update release notes for #2374 * update release notes for #2374 Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: Yecheng Fu <fuyecheng@pingcap.com> Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fixes #2473
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: