rewrite e2e #346
Merged
rewrite e2e #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-tests |
|
/run-e2e-tests |
2 similar comments
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
2 similar comments
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
|
/run-e2e-tests |
5 similar comments
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
weekface
reviewed
Mar 27, 2019
| @@ -315,6 +341,12 @@ func (oa *operatorActions) CleanTidbCluster(info *TidbClusterInfo) error { | |||
| } | |||
| } | |||
|
|
|||
| // delete all jobs | |||
| allJobsSet := label.Label{}.Instance(info.ClusterName).String() | |||
There was a problem hiding this comment.
Suggested change
| allJobsSet := label.Label{}.Instance(info.ClusterName).String() | |
| allJobsSet := label.New().Instance(info.ClusterName).String() |
There was a problem hiding this comment.
the namespace contains some jobs which label app.kubernetes.io/managed-by: Tiller.
these jobs cannot be select by label.New()
| command: | ||
| - /usr/local/bin/e2e | ||
| - --operator-tag=e2e | ||
| - --operator-image=pingcap/tidb-operator:latest |
There was a problem hiding this comment.
Suggested change
| - --operator-image=pingcap/tidb-operator:latest | |
| - --operator-image=localhost:5000/pingcap/tidb-operator:latest |
|
/run-e2e-tests |
weekface
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr rewrite e2e test and refactor the test code. the test contains e2e test and stability test.