Update e2e workflow in CONTRIBUTING.md #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cofyc
commented
Apr 15, 2019
| @@ -27,7 +27,7 @@ spec: | |||
| serviceAccount: tidb-operator-e2e | |||
| containers: | |||
| - name: tidb-operator-e2e | |||
| image: "" | |||
There was a problem hiding this comment.
@xiaojingchen
Not sure why it is empty in your #346 PR, can we give it a default value, then it can be applied by kubectl?
There was a problem hiding this comment.
this's ok. in fact the image will be replaced when e2e ci running.
|
/run-e2e-tests |
- use `[` instead of `[[` to be sh-compatible (SHELL defaults to sh on linux)
|
CI failed, because these is a gofmt issue caused by pr #386, you can fix it in this pr or just ignore it. |
|
It has been fixed here, so I rebased on master and try again. |
weekface
approved these changes
Apr 16, 2019
| [[ -d tests/images/e2e/tidb-operator ]] && rm -r tests/images/e2e/tidb-operator || true | ||
| [[ -d tests/images/e2e/tidb-cluster ]] && rm -r tests/images/e2e/tidb-cluster || true | ||
| [[ -d tests/images/e2e/tidb-backup ]] && rm -r tests/images/e2e/tidb-backup || true | ||
| [ -d tests/images/e2e/tidb-operator ] && rm -r tests/images/e2e/tidb-operator || true |
xiaojingchen
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[instead of[[to be sh-compatible (more portable)make e2e-dockerbuilds e2e image fromtests/images/e2einstead ofimages/tidb-operator-e2e, we should use new e2e yaml filetests/manifests/e2e/e2e.yaml.xref: #346