Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Deprecate unnecessary Helm Chart deployment #4319

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

mianhk
Copy link
Contributor

@mianhk mianhk commented Dec 22, 2021

What problem does this PR solve?

Deprecate parts of unnecessary Helm Chart deployment, ref: #4254.
On the other hand, the PR(#4170 ) needs to fix some of e2e tests. ref: #4170 (comment).

The following parts have been deprecated in this PR:

  • deprecate TidbClusterConfig in e2e tests.
  • deprecate installing pump by Helm in e2e tests.
  • delete other unused files and functions.

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:
  • I delete the file docs/stability-test-cookbook.md and test files around it. Don't know if there are any other effects.

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

Deprecate unnecessary Helm Chart deployment.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

…m-install

Conflicts:
	tests/cmd/stability/main.go
	tests/e2e/tidbcluster/tidbcluster.go
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2021

Codecov Report

Merging #4319 (422c5bd) into master (e07e29d) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4319      +/-   ##
==========================================
- Coverage   62.58%   62.57%   -0.02%     
==========================================
  Files         183      183              
  Lines       19452    19452              
==========================================
- Hits        12174    12172       -2     
- Misses       6145     6146       +1     
- Partials     1133     1134       +1     
Flag Coverage Δ
unittest 62.57% <ø> (-0.02%) ⬇️

@KanShiori
Copy link
Collaborator

@mianhk CI failed

@mianhk mianhk changed the title Deprecate unnecessary Helm Chart deployment [WIP]Deprecate unnecessary Helm Chart deployment Dec 27, 2021
@ti-chi-bot
Copy link
Member

@mianhk: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants