-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Deprecate unnecessary Helm Chart deployment #4319
base: master
Are you sure you want to change the base?
Conversation
and strcut in e2e tests.
…m-install Conflicts: tests/e2e/tidbcluster/tidbcluster.go
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
…m-install Conflicts: tests/cmd/stability/main.go tests/e2e/tidbcluster/tidbcluster.go
Codecov Report
@@ Coverage Diff @@
## master #4319 +/- ##
==========================================
- Coverage 62.58% 62.57% -0.02%
==========================================
Files 183 183
Lines 19452 19452
==========================================
- Hits 12174 12172 -2
- Misses 6145 6146 +1
- Partials 1133 1134 +1
|
@mianhk CI failed |
@mianhk: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Deprecate parts of unnecessary Helm Chart deployment, ref: #4254.
On the other hand, the PR(#4170 ) needs to fix some of e2e tests. ref: #4170 (comment).
The following parts have been deprecated in this PR:
TidbClusterConfig
in e2e tests.What is changed and how does it work?
Code changes
Tests
Side effects
docs/stability-test-cookbook.md
and test files around it. Don't know if there are any other effects.Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.