-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate unnecessary Helm Chart deployment #4507
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #4507 +/- ##
==========================================
+ Coverage 62.79% 72.41% +9.62%
==========================================
Files 184 188 +4
Lines 19875 22294 +2419
==========================================
+ Hits 12480 16144 +3664
+ Misses 6262 5038 -1224
+ Partials 1133 1112 -21
|
/run-all-tests |
1 similar comment
/run-all-tests |
/test pull-e2e-kind-serial pull-e2e-kind-br pull-e2e-kind-across-kubernetes |
2 similar comments
/test pull-e2e-kind-serial pull-e2e-kind-br pull-e2e-kind-across-kubernetes |
/test pull-e2e-kind-serial pull-e2e-kind-br pull-e2e-kind-across-kubernetes |
/test pull-e2e-kind-br pull-e2e-kind-across-kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 7d11f92
|
What problem does this PR solve?
Same as #4319
Ref #4254
What is changed and how does it work?
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.