Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unnecessary Helm Chart deployment #4507

Merged
merged 5 commits into from
Apr 15, 2022

Conversation

KanShiori
Copy link
Collaborator

What problem does this PR solve?

Same as #4319
Ref #4254

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 13, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • DanielZhangQD
  • csuzhangxc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2022

Codecov Report

Merging #4507 (7d11f92) into master (b8382da) will increase coverage by 9.62%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4507      +/-   ##
==========================================
+ Coverage   62.79%   72.41%   +9.62%     
==========================================
  Files         184      188       +4     
  Lines       19875    22294    +2419     
==========================================
+ Hits        12480    16144    +3664     
+ Misses       6262     5038    -1224     
+ Partials     1133     1112      -21     
Flag Coverage Δ
e2e 60.35% <ø> (?)
unittest 62.77% <ø> (-0.03%) ⬇️

@KanShiori
Copy link
Collaborator Author

/run-all-tests

1 similar comment
@KanShiori
Copy link
Collaborator Author

/run-all-tests

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind-serial pull-e2e-kind-br pull-e2e-kind-across-kubernetes

2 similar comments
@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind-serial pull-e2e-kind-br pull-e2e-kind-across-kubernetes

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind-serial pull-e2e-kind-br pull-e2e-kind-across-kubernetes

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind-br pull-e2e-kind-across-kubernetes

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7d11f92

@ti-chi-bot ti-chi-bot merged commit d256c36 into pingcap:master Apr 15, 2022
xhebox pushed a commit to KanShiori/tidb-operator that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants