Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add design doc for ebs br support to multiple k8s clusters #5004

Merged
merged 7 commits into from
Aug 25, 2023

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented May 11, 2023

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Signed-off-by: BornChanger <dawn_catcher@126.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 11, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from csuzhangxc and handlerww May 11, 2023 03:14
@BornChanger
Copy link
Contributor Author

/cc @WangLe1321 @grovecai

@ti-chi-bot ti-chi-bot bot requested review from grovecai and WangLe1321 May 11, 2023 03:14
@BornChanger
Copy link
Contributor Author

/retest

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2023

Codecov Report

Merging #5004 (111e006) into master (3058685) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5004      +/-   ##
==========================================
- Coverage   57.30%   57.26%   -0.04%     
==========================================
  Files         243      243              
  Lines       27298    27308      +10     
==========================================
- Hits        15642    15637       -5     
- Misses      10135    10148      +13     
- Partials     1521     1523       +2     
Flag Coverage Δ
unittest 57.26% <ø> (-0.04%) ⬇️

Signed-off-by: BornChanger <dawn_catcher@126.com>
@ti-chi-bot ti-chi-bot bot added the size/L label Aug 21, 2023
Signed-off-by: WangLe1321 <wangle1321@163.com>
@ti-chi-bot ti-chi-bot bot removed the lgtm label Aug 25, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 25, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc, WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [WangLe1321,csuzhangxc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-25 09:12:56.67781958 +0000 UTC m=+1486341.226835568: ☑️ agreed by csuzhangxc.
  • 2023-08-25 09:15:21.160404927 +0000 UTC m=+1486485.709420934: ✖️🔁 reset by ti-chi-bot[bot].
  • 2023-08-25 09:59:28.199274398 +0000 UTC m=+1489132.748290385: ☑️ agreed by WangLe1321.

@csuzhangxc csuzhangxc merged commit f5be3c7 into pingcap:master Aug 25, 2023
6 checks passed
@csuzhangxc
Copy link
Member

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 25, 2023

@csuzhangxc: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.5: #5270.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

csuzhangxc pushed a commit that referenced this pull request Aug 25, 2023
…) (#5270)

Signed-off-by: BornChanger <dawn_catcher@126.com>
Signed-off-by: WangLe1321 <wangle1321@163.com>
Co-authored-by: BornChanger <dawn_catcher@126.com>
Co-authored-by: WangLe1321 <wangle1321@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants