Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: add warmup process to volume snapshot restore #5229

Merged
merged 19 commits into from
Aug 18, 2023
Merged

br: add warmup process to volume snapshot restore #5229

merged 19 commits into from
Aug 18, 2023

Conversation

WangLe1321
Copy link
Contributor

@WangLe1321 WangLe1321 commented Aug 8, 2023 •
edited
Loading

What problem does this PR solve?

Closes #5228

Closes #5200

Closes #5160

Closes #5235

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

@WangLe1321
br: add warmup process to volume snapshot restore
aa01693 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@WangLe1321
br: refactor warmup job
2b7a19c 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@WangLe1321
br: modify warmup command
494c809 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@WangLe1321
br: add security context to warmup container
df6a25b 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@WangLe1321
br: modify to warmup tikv volumes async
919b03f 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@WangLe1321
br: fix warmup template
3b56eda 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@WangLe1321
br: modify fio image
98c0ed6 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@WangLe1321
br: add warmup param to restore CR
926cc23 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@WangLe1321
br: fix warmup args
6d25ee0 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@WangLe1321
br: add resource requirements to warmup pod
8175313 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@WangLe1321
br: add warmup information to VolumeRestore CR
9eb06d2 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@ti-chi-bot ti-chi-bot bot added the size/XXL label Aug 8, 2023
@ti-chi-bot ti-chi-bot bot requested a review from lichunzhu August 8, 2023 06:50
@WangLe1321
br: add restore name to warmup job name
884e474 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@WangLe1321
Copy link
Contributor Author

/test pull-e2e-kind pull-e2e-kind-across-kubernetes

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 8, 2023

@WangLe1321: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 8, 2023

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2023 •
edited
Loading

Codecov Report

Merging #5229 (3b25d53) into master (88af89a) will increase coverage by 3.27%.
The diff coverage is 15.69%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5229      +/-   ##
==========================================
+ Coverage   57.76%   61.03%   +3.27%     
==========================================
  Files         246      249       +3     
  Lines       29480    33253    +3773     
==========================================
+ Hits        17028    20296    +3268     
- Misses      10796    11220     +424     
- Partials     1656     1737      +81
Flag Coverage Δ
e2e 33.35% <6.97%> (?)
unittest 57.28% <14.04%> (-0.48%) ⬇️

@WangLe1321
Copy link
Contributor Author

/test pull-e2e-kind

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 8, 2023

@WangLe1321: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 8, 2023

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@WangLe1321
Copy link
Contributor Author

/test pull-e2e-kind-across-kubernetes

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 8, 2023

@WangLe1321: The label(s) /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 8, 2023

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger BornChanger mentioned this pull request Aug 9, 2023
Open
@YuJuncen YuJuncen mentioned this pull request Aug 10, 2023
Merged
10 tasks
@WangLe1321
br: fix async warmup status
4c7daa7 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@WangLe1321
br: modify set complete status after warmup complete for vrt
e7d570a 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@WangLe1321
br: modify status of vrt with warmup
223da5c 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@WangLe1321
Copy link
Contributor Author

/test pull-e2e-kind-br pull-e2e-kind

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

@WangLe1321: The label(s) /pull-e2e-kind-br, /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-br pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-br pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@WangLe1321
Copy link
Contributor Author

/test pull-e2e-kind-br

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

@WangLe1321: The label(s) /pull-e2e-kind-br cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@WangLe1321
Copy link
Contributor Author

/test pull-e2e-kind-br

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

@WangLe1321: The label(s) /pull-e2e-kind-br cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@WangLe1321
Copy link
Contributor Author

/test pull-e2e-kind

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

@WangLe1321: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@WangLe1321
Copy link
Contributor Author

/test pull-e2e-kind

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

@WangLe1321: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-18 08:24:50.956615832 +0000 UTC m=+878655.505631819: ☑️ agreed by BornChanger.

@WangLe1321
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

@WangLe1321: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BornChanger,csuzhangxc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc csuzhangxc merged commit 132b2b5 into pingcap:master Aug 18, 2023
4 checks passed
@WangLe1321
Copy link
Contributor Author

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

@WangLe1321: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 18, 2023
Merged
10 tasks
@ti-chi-bot
Copy link
Member

@WangLe1321: new pull request created to branch release-1.5: #5253.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

csuzhangxc pushed a commit that referenced this pull request Aug 18, 2023
@ti-chi-bot
br: add warmup process to volume snapshot restore (#5229) (#5253)
43925b3
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 18, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BornChanger BornChanger BornChanger approved these changes

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees
No one assigned
Labels
approved area/ebs-br lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warm up tikv volumes during EBS restore ebs br: avoid to allocate warmup pods to the same node
5 participants
@WangLe1321 @codecov-commenter @ti-chi-bot @csuzhangxc @BornChanger