-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backup: added ebs-warmup for restoring from EBS snapshots #5238
Conversation
Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5238 +/- ##
=======================================
Coverage 57.76% 57.76%
=======================================
Files 246 246
Lines 29480 29480
=======================================
Hits 17028 17028
Misses 10796 10796
Partials 1656 1656
|
/retest |
Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
@YuJuncen: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, WangLe1321 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.5 |
@BornChanger: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@BornChanger: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[LGTM Timeline notifier]Timeline:
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@BornChanger: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
This PR added a new image named
ebs-warmup
which supports scanning the newly restored volumes. So we can get rid of the poor performance while the volume contents are still pending in S3.What is changed and how does it work?
For example:
cc #5229
This newly added image is for the
WarmUp
stage of restoring.Close #5224
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.