Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup: added ebs-warmup for restoring from EBS snapshots #5238

Merged
merged 7 commits into from
Aug 18, 2023

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Aug 10, 2023

What problem does this PR solve?

This PR added a new image named ebs-warmup which supports scanning the newly restored volumes. So we can get rid of the poor performance while the volume contents are still pending in S3.

What is changed and how does it work?

For example:
cc #5229
This newly added image is for the WarmUp stage of restoring.

Close #5224

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test (I think the E2E might be done along with volume restore. But I'm not sure whether there are infra for them.)
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

None

Signed-off-by: hillium <yujuncen@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Aug 10, 2023

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/XXL label Aug 10, 2023
Signed-off-by: hillium <yujuncen@pingcap.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #5238 (96e2071) into master (88af89a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5238   +/-   ##
=======================================
  Coverage   57.76%   57.76%           
=======================================
  Files         246      246           
  Lines       29480    29480           
=======================================
  Hits        17028    17028           
  Misses      10796    10796           
  Partials     1656     1656           
Flag Coverage Δ
unittest 57.76% <ø> (ø)

@BornChanger BornChanger requested review from csuzhangxc and WangLe1321 and removed request for lichunzhu August 10, 2023 10:25
@BornChanger
Copy link
Contributor

/retest

Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot removed the lgtm label Aug 18, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

@YuJuncen: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BornChanger,WangLe1321]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 18, 2023
@BornChanger
Copy link
Contributor

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@BornChanger: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

@BornChanger: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot removed the lgtm label Aug 18, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-18 07:33:59.841600864 +0000 UTC m=+875604.390616851: ☑️ agreed by WangLe1321.
  • 2023-08-18 07:35:20.409938472 +0000 UTC m=+875684.958954453: ✖️🔁 reset by ti-chi-bot[bot].
  • 2023-08-18 08:23:07.327256677 +0000 UTC m=+878551.876272663: ☑️ agreed by BornChanger.
  • 2023-08-18 09:29:57.639914656 +0000 UTC m=+882562.188930643: ✖️🔁 reset by WangLe1321.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

New changes are detected. LGTM label has been removed.

@csuzhangxc csuzhangxc merged commit aeed0a4 into pingcap:master Aug 18, 2023
4 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb-operator that referenced this pull request Aug 18, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@BornChanger: new pull request created to branch release-1.5: #5254.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

csuzhangxc pushed a commit that referenced this pull request Aug 18, 2023
)

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Co-authored-by: WangLe1321 <wangle1321@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ebs br: checkpointing volume warmup support
7 participants