Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ebs-warmup: added test cases && better exit logic #5272

Merged
merged 4 commits into from
Sep 15, 2023
Merged

ebs-warmup: added test cases && better exit logic #5272

merged 4 commits into from
Sep 15, 2023

Conversation

YuJuncen
Copy link
Contributor

What problem does this PR solve?

The warmup binary hasn't been tested enough yet. And it may not be properly exited once SIGINT received.

What is changed and how does it work?

This PR make the procedure of sending requests abortable, and added some unit tests for this binary.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

NONE

@YuJuncen
added test cases && better exit logic for warmup
db3ba30 
Signed-off-by: hillium <yujuncen@pingcap.com>
@YuJuncen
added to makefile
48b76f2 
Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot requested a review from lichunzhu August 29, 2023 06:23
@ti-chi-bot ti-chi-bot bot added the size/XL label Aug 29, 2023
@YuJuncen YuJuncen changed the title added test cases && better exit logic for warmup ebs-warmup: added test cases && better exit logic Aug 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023 •
edited
Loading

Codecov Report

Merging #5272 (529a1f4) into master (6702782) will increase coverage by 6.80%.
The diff coverage is 76.19%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5272      +/-   ##
==========================================
+ Coverage   57.51%   64.31%   +6.80%     
==========================================
  Files         249      255       +6     
  Lines       30193    33957    +3764     
==========================================
+ Hits        17366    21840    +4474     
+ Misses      11114    10343     -771     
- Partials     1713     1774      +61
Flag Coverage Δ
e2e 47.80% <ø> (?)
unittest 57.58% <76.19%> (+0.07%) ⬆️

@YuJuncen
added header
f3fffe0 
Signed-off-by: hillium <yujuncen@pingcap.com>
@BornChanger
Copy link
Contributor

/retest

@BornChanger
Copy link
Contributor

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@BornChanger: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 4, 2023

@BornChanger: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@BornChanger
Copy link
Contributor

/run pull-e2e-kind-tikv-scale-simultaneously

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 5, 2023

@BornChanger: The label(s) /pull-e2e-kind-tikv-scale-simultaneously cannot be applied, because the repository doesn't have them.

In response to this:

/run pull-e2e-kind-tikv-scale-simultaneously

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@BornChanger
Copy link
Contributor

/retest

@BornChanger BornChanger mentioned this pull request Sep 5, 2023
Open
@BornChanger
Copy link
Contributor

/retest

@BornChanger
Copy link
Contributor

/test pull-e2e-kind-across-kubernetes

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 8, 2023

@BornChanger: The label(s) /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 8, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor

/test pull-e2e-kind-tikv-scale-simultaneously

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 11, 2023

@BornChanger: The label(s) /pull-e2e-kind-tikv-scale-simultaneously cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-tikv-scale-simultaneously

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 11, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-tikv-scale-simultaneously

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger BornChanger requested review from BornChanger and WangLe1321 and removed request for lichunzhu September 13, 2023 02:46
@BornChanger BornChanger self-requested a review September 13, 2023 09:12
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 13, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-13 07:44:06.551961146 +0000 UTC m=+71412.519549183: ☑️ agreed by BornChanger.
  • 2023-09-13 07:48:55.995478393 +0000 UTC m=+71701.963066428: ✖️🔁 reset by ti-chi-bot[bot].
  • 2023-09-13 09:13:12.290576196 +0000 UTC m=+76758.258164245: ☑️ agreed by BornChanger.

@BornChanger
Copy link
Contributor

/retest

@BornChanger
Copy link
Contributor

/test pull-e2e-kind-serial

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 13, 2023

@BornChanger: The label(s) /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 13, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor

/test pull-e2e-kind-basic pull-e2e-kind-across-kubernetes pull-e2e-kind

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 13, 2023

@BornChanger: The label(s) /pull-e2e-kind-basic, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-basic pull-e2e-kind-across-kubernetes pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 13, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-basic pull-e2e-kind-across-kubernetes pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor

/test pull-e2e-kind

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 15, 2023

@BornChanger: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 15, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@WangLe1321
Copy link
Contributor

/test pull-e2e-kind-across-kubernetes pull-e2e-kind-basic

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 15, 2023

@WangLe1321: The label(s) /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-basic cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 15, 2023

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-across-kubernetes pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BornChanger,WangLe1321]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BornChanger
Copy link
Contributor

/test pull-e2e-kind-basic

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 15, 2023

@BornChanger: The label(s) /pull-e2e-kind-basic cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 15, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor

/test pull-e2e-kind-basic

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 15, 2023

@BornChanger: The label(s) /pull-e2e-kind-basic cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 15, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 2c3cd13 into pingcap:master Sep 15, 2023
4 checks passed
@ti-chi-bot
Copy link
Member

@BornChanger: new pull request created to branch release-1.5: #5290.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 15, 2023
Merged
10 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb-operator that referenced this pull request Sep 15, 2023
@YuJuncen @ti-chi-bot
This is an automated cherry-pick of pingcap#5272
82d80ed 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
csuzhangxc pushed a commit that referenced this pull request Sep 18, 2023
@ti-chi-bot @YuJuncen @BornChanger
ebs-warmup: added test cases && better exit logic (#5272) (#5290)
6c6c99c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Co-authored-by: BornChanger <97348524+BornChanger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BornChanger BornChanger BornChanger approved these changes

@WangLe1321 WangLe1321 WangLe1321 approved these changes

Assignees
No one assigned
Labels
approved area/ebs-br lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YuJuncen @codecov-commenter @BornChanger @ti-chi-bot @WangLe1321