-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ebs-warmup: added test cases && better exit logic (#5272) #5290
ebs-warmup: added test cases && better exit logic (#5272) #5290
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-1.5 #5290 +/- ##
===============================================
+ Coverage 57.53% 64.96% +7.42%
===============================================
Files 251 258 +7
Lines 30210 34082 +3872
===============================================
+ Hits 17382 22140 +4758
+ Misses 11122 10174 -948
- Partials 1706 1768 +62
|
/retest |
/test pull-e2e-kind-tikv-scale-simultaneously |
@BornChanger: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@BornChanger: No presubmit jobs available for pingcap/tidb-operator@release-1.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, WangLe1321 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #5272
What problem does this PR solve?
The
warmup
binary hasn't been tested enough yet. And it may not be properly exited onceSIGINT
received.What is changed and how does it work?
This PR make the procedure of sending requests abortable, and added some unit tests for this binary.
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.