Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs-warmup: added test cases && better exit logic (#5272) #5290

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5272

What problem does this PR solve?

The warmup binary hasn't been tested enough yet. And it may not be properly exited once SIGINT received.

What is changed and how does it work?

This PR make the procedure of sending requests abortable, and added some unit tests for this binary.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

NONE

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Makefile Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2023

Codecov Report

Merging #5290 (1d153d2) into release-1.5 (d5d4b38) will increase coverage by 7.42%.
The diff coverage is 76.19%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.5    #5290      +/-   ##
===============================================
+ Coverage        57.53%   64.96%   +7.42%     
===============================================
  Files              251      258       +7     
  Lines            30210    34082    +3872     
===============================================
+ Hits             17382    22140    +4758     
+ Misses           11122    10174     -948     
- Partials          1706     1768      +62     
Flag Coverage Δ
e2e 48.55% <ø> (?)
unittest 57.60% <76.19%> (+0.07%) ⬆️

@BornChanger
Copy link
Contributor

/retest

@BornChanger
Copy link
Contributor

/test pull-e2e-kind-tikv-scale-simultaneously

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 15, 2023

@BornChanger: The label(s) /pull-e2e-kind-tikv-scale-simultaneously cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-tikv-scale-simultaneously

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 15, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@release-1.5

In response to this:

/test pull-e2e-kind-tikv-scale-simultaneously

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 16, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-16 03:32:14.060019963 +0000 UTC m=+315500.027607998: ☑️ agreed by BornChanger.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 16, 2023
@BornChanger BornChanger requested review from WangLe1321 and removed request for howardlau1999 and shonge September 16, 2023 03:34
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BornChanger,WangLe1321]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc csuzhangxc merged commit 6c6c99c into pingcap:release-1.5 Sep 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants