Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always save checkpoint to the warmup folder #5507

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Jan 9, 2024

What problem does this PR solve?

Fixed #5506.

What is changed and how does it work?

The checkpoint file is stored at the work directory where the warmup binary runs. And in most cases, it is / and won't be persisted to a PV.
This PR changes the warmup_step script, make it always set checkpoint to the directory to be warmed up(Which is probably a real EBS disk).
(Also notice that, it is impossible to pass a glob pattern to warmup_step anymore.)

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

Fixed a bug that may cause the warmup checkpoint is unavailable.

Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the size/M label Jan 9, 2024
Signed-off-by: hillium <yujuncen@pingcap.com>
@BornChanger
Copy link
Contributor

/retest

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1fcdf52) 61.32% compared to head (a83fced) 61.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5507      +/-   ##
==========================================
- Coverage   61.32%   61.32%   -0.01%     
==========================================
  Files         234      234              
  Lines       29985    29996      +11     
==========================================
+ Hits        18388    18394       +6     
- Misses       9758     9760       +2     
- Partials     1839     1842       +3     
Flag Coverage Δ
unittest 61.32% <80.00%> (-0.01%) ⬇️

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 16, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 16, 2024
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jan 16, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-16 14:45:10.58439663 +0000 UTC m=+280752.148694335: ☑️ agreed by BornChanger.
  • 2024-01-16 14:47:01.952144365 +0000 UTC m=+280863.516442069: ✖️🔁 reset by ti-chi-bot[bot].

Copy link
Contributor

ti-chi-bot bot commented Jan 16, 2024

New changes are detected. LGTM label has been removed.

@csuzhangxc csuzhangxc merged commit 197f1fe into pingcap:master Jan 16, 2024
5 of 6 checks passed
@BornChanger
Copy link
Contributor

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@BornChanger: new pull request created to branch release-1.5: #5522.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File based warmup checkpoint is unavailable if the root directory isn't a PV
5 participants