ebs br: always save checkpoint to the warmup folder (#5507) #5522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #5507
What problem does this PR solve?
Fixed #5506.
What is changed and how does it work?
The checkpoint file is stored at the work directory where the
warmup
binary runs. And in most cases, it is/
and won't be persisted to a PV.This PR changes the
warmup_step
script, make it always set checkpoint to the directory to be warmed up(Which is probably a real EBS disk).(Also notice that, it is impossible to pass a glob pattern to
warmup_step
anymore.)Code changes
Tests
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.