Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs br: always save checkpoint to the warmup folder (#5507) #5522

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5507

What problem does this PR solve?

Fixed #5506.

What is changed and how does it work?

The checkpoint file is stored at the work directory where the warmup binary runs. And in most cases, it is / and won't be persisted to a PV.
This PR changes the warmup_step script, make it always set checkpoint to the directory to be warmed up(Which is probably a real EBS disk).
(Also notice that, it is impossible to pass a glob pattern to warmup_step anymore.)

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

Fixed a bug that may cause the warmup checkpoint is unavailable.

Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
Copy link
Contributor

ti-chi-bot bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tennix for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from KanShiori and shonge January 16, 2024 15:05
@BornChanger
Copy link
Contributor

/retest

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d67387a) 61.56% compared to head (ab67e17) 61.06%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.5    #5522      +/-   ##
===============================================
- Coverage        61.56%   61.06%   -0.51%     
===============================================
  Files              228      241      +13     
  Lines            29174    33127    +3953     
===============================================
+ Hits             17962    20230    +2268     
- Misses            9443    11035    +1592     
- Partials          1769     1862      +93     
Flag Coverage Δ
e2e 23.22% <ø> (?)
unittest 61.57% <80.00%> (+<0.01%) ⬆️

@BornChanger BornChanger changed the title always save checkpoint to the warmup folder (#5507) ebs br: always save checkpoint to the warmup folder (#5507) Jan 16, 2024
@csuzhangxc csuzhangxc merged commit 1d8aa7e into pingcap:release-1.5 Jan 16, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants