Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CreationTimestamp of volumebackup for gc check #5518

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Use CreationTimestamp of volumebackup for gc check #5518

merged 5 commits into from
Jan 17, 2024

Conversation

BornChanger
Copy link
Contributor

What problem does this PR solve?

Closes #5517

What is changed and how does it work?

When GC expired volumebackup, we need to use creationtimestamp instead of commitTS, since commitTS is empty for failed backup.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

@ti-chi-bot ti-chi-bot bot added the size/XS label Jan 12, 2024
@BornChanger BornChanger changed the title Use creation ts for gc Use CreationTimestamp of volumebackup for gc check Jan 12, 2024
@BornChanger
Copy link
Contributor Author

/cc @WangLe1321 @YuJuncen

@ti-chi-bot ti-chi-bot bot added size/S and removed size/XS labels Jan 12, 2024
@BornChanger
ebs br: use createTimeStamp of vbk for GC check
6a39b11 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
*: adjust case
645a4b6 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
*: simple compare
e8f668b 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@ti-chi-bot ti-chi-bot bot added size/M and removed size/S labels Jan 12, 2024
@BornChanger
Copy link
Contributor Author

/retest

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1fcdf52) 61.32% compared to head (e8f668b) 66.88%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5518      +/-   ##
==========================================
+ Coverage   61.32%   66.88%   +5.55%     
==========================================
  Files         234      245      +11     
  Lines       29985    33843    +3858     
==========================================
+ Hits        18388    22635    +4247     
+ Misses       9758     9307     -451     
- Partials     1839     1901      +62
Flag Coverage Δ
e2e 45.58% <ø> (?)
unittest 61.31% <100.00%> (-0.02%) ⬇️

@BornChanger
Copy link
Contributor Author

/test-pull-e2e-kind-across-kubernetes

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 15, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 15, 2024
@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind-across-kubernetes

@ti-chi-bot ti-chi-bot bot removed the lgtm label Jan 16, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-15 10:11:29.263569026 +0000 UTC m=+177930.827866721: ☑️ agreed by WangLe1321.
  • 2024-01-16 15:03:59.686032614 +0000 UTC m=+281881.250330317: ✖️🔁 reset by ti-chi-bot[bot].

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 16, 2024

New changes are detected. LGTM label has been removed.

@BornChanger BornChanger mentioned this pull request Jan 16, 2024
Open
@csuzhangxc csuzhangxc merged commit 3bd2bad into pingcap:master Jan 17, 2024
5 checks passed
@BornChanger
Copy link
Contributor Author

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@BornChanger: new pull request created to branch release-1.5: #5523.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 17, 2024
Merged
10 tasks
csuzhangxc added a commit that referenced this pull request Jan 17, 2024
@ti-chi-bot @BornChanger @csuzhangxc
Use CreationTimestamp of volumebackup for gc check (#5518) (#5523)
bb0424a 
Signed-off-by: BornChanger <dawn_catcher@126.com>
Co-authored-by: BornChanger <dawn_catcher@126.com>
Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangLe1321 WangLe1321 WangLe1321 approved these changes

@howardlau1999 howardlau1999 Awaiting requested review from howardlau1999

@YuJuncen YuJuncen Awaiting requested review from YuJuncen

Assignees
No one assigned
Labels
approved area/ebs-br size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ebs br: failed volumebackup gc prematurely
5 participants
@BornChanger @codecov-commenter @ti-chi-bot @WangLe1321 @csuzhangxc