Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CreationTimestamp of volumebackup for gc check (#5518) #5523

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5518

What problem does this PR solve?

Closes #5517

What is changed and how does it work?

When GC expired volumebackup, we need to use creationtimestamp instead of commitTS, since commitTS is empty for failed backup.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Signed-off-by: BornChanger <dawn_catcher@126.com>
Signed-off-by: BornChanger <dawn_catcher@126.com>
Signed-off-by: BornChanger <dawn_catcher@126.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (227db87) 61.62% compared to head (9cac6e5) 61.65%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.5    #5523      +/-   ##
===============================================
+ Coverage        61.62%   61.65%   +0.02%     
===============================================
  Files              228      228              
  Lines            29152    29150       -2     
===============================================
+ Hits             17966    17973       +7     
+ Misses            9422     9417       -5     
+ Partials          1764     1760       -4     
Flag Coverage Δ
unittest 61.65% <100.00%> (+0.02%) ⬆️

@pingcap pingcap deleted a comment from ti-chi-bot bot Jan 17, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from bornchanger. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc csuzhangxc merged commit bb0424a into pingcap:release-1.5 Jan 17, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants