add tidb permit host option #779

shonge · 2019-08-16T07:03:56Z

What problem does this PR solve?

#733

What is changed and how does it work?

Add an option permitHost in values, and add the logic in _initialize_tidb_users.py.tpl

Check List

Tests

Manual test

Code changes

Has Helm charts change

Side effects

None

Related changes

Need to update the documentation

Does this PR introduce a user-facing change?:

Users can designate permitting host in chart values.tidb.permitHost

sre-bot · 2019-08-16T07:04:00Z

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

sre-bot · 2019-08-16T07:04:01Z

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

CLAassistant · 2019-08-16T07:04:01Z

All committers have signed the CLA.

charts/tidb-cluster/values.yaml

charts/tidb-cluster/templates/scripts/_initialize_tidb_users.py.tpl

charts/tidb-cluster/templates/tidb-initializer-job.yaml

Co-Authored-By: Tennix <tennix@users.noreply.github.com>

move permitHost after passwordSecretName

…y.tpl Co-Authored-By: Tennix <tennix@users.noreply.github.com>

weekface · 2019-08-16T08:57:22Z

/run-e2e-in-kind

fix default permit host quote

tennix

LGTM

weekface · 2019-08-22T06:25:08Z

/run-e2e-in-kind

weekface · 2019-08-22T07:36:09Z

@shonge The e2e failed, can't set password to the tidb cluster

$ kubectl logs -f -n e2e cluster4-tidb-initializer-kfwbt
Traceback (most recent call last):
  File "<string>", line 18, in <module>
  File "/usr/local/lib/python3.6/site-packages/MySQLdb/cursors.py", line 206, in execute
    res = self._query(query)
  File "/usr/local/lib/python3.6/site-packages/MySQLdb/cursors.py", line 312, in _query
    db.query(q)
  File "/usr/local/lib/python3.6/site-packages/MySQLdb/connections.py", line 224, in query
    _mysql.connection.query(self, query)
MySQLdb._exceptions.OperationalError: (1133, "Can't find any matching row in the user table")

https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/operator_ghpr_e2e_test_kind/detail/operator_ghpr_e2e_test_kind/135/pipeline

PTAL

weekface · 2019-08-26T04:08:22Z

/run-e2e-in-kind

shonge · 2019-08-27T04:49:12Z

@weekface @tennix PTAL

weekface

LGTM, thank you.

weekface · 2019-08-27T09:07:10Z

/run-e2e-in-kind

weekface · 2019-08-28T02:26:30Z

/run-e2e-in-kind

weekface · 2019-08-28T06:07:33Z

/run-e2e-in-kind

tennix

LGTM

charts/tidb-cluster/templates/scripts/_initialize_tidb_users.py.tpl

weekface · 2019-09-04T08:23:18Z

/run-e2e-in-kind

weekface · 2019-09-04T11:29:25Z

/run-e2e-in-kind

cofyc · 2019-09-09T09:48:22Z

/run-e2e-in-kind

cofyc

LGTM

cofyc · 2019-09-09T09:59:21Z

@weekface @tennix The reviews were dismissed in last commit. PTAL again.

tennix

LGTM

sre-bot · 2019-09-09T11:16:06Z

cherry pick to release-1.0 in PR #893

cofyc · 2019-09-09T11:23:55Z

Thanks for your contribution!

* add grant permit host option. * fixed "Can't find any matching in user table" * add permitHost trigger to job.yaml * Update charts/tidb-cluster/values.yaml Co-Authored-By: Tennix <tennix@users.noreply.github.com> * Update tidb-initializer-job.yaml move permitHost after passwordSecretName * Update charts/tidb-cluster/templates/scripts/_initialize_tidb_users.py.tpl Co-Authored-By: Tennix <tennix@users.noreply.github.com> * Update _initialize_tidb_users.py.tpl * Update _initialize_tidb_users.py.tpl fix default permit host quote * fix access denied for root when executing initsql. * delete two duplicate commit lines

shonge added 3 commits August 6, 2019 19:29

add grant permit host option.

4a15d4d

fixed "Can't find any matching in user table"

681c3ec

add permitHost trigger to job.yaml

da1f8b7

Merge branch 'master' into init_tidb

9c1f4ea

weekface added the needs-cherry-pick-1.0 label Aug 16, 2019

tennix reviewed Aug 16, 2019

View reviewed changes

charts/tidb-cluster/values.yaml Outdated Show resolved Hide resolved

charts/tidb-cluster/templates/scripts/_initialize_tidb_users.py.tpl Outdated Show resolved Hide resolved

charts/tidb-cluster/templates/tidb-initializer-job.yaml Outdated Show resolved Hide resolved

shonge and others added 5 commits August 16, 2019 16:12

Update charts/tidb-cluster/values.yaml

f62d06f

Co-Authored-By: Tennix <tennix@users.noreply.github.com>

Update tidb-initializer-job.yaml

0a79142

move permitHost after passwordSecretName

Update charts/tidb-cluster/templates/scripts/_initialize_tidb_users.p…

38482d5

…y.tpl Co-Authored-By: Tennix <tennix@users.noreply.github.com>

Update _initialize_tidb_users.py.tpl

8104cfd

Merge branch 'master' into init_tidb

e16eba1

Update _initialize_tidb_users.py.tpl

9cc3b2c

fix default permit host quote

tennix previously approved these changes Aug 20, 2019

View reviewed changes

Merge branch 'master' into init_tidb

647ade9

weekface previously approved these changes Aug 22, 2019

View reviewed changes

weekface mentioned this pull request Aug 22, 2019

add a test case to cover #779: add tidb permit host option #807

Closed

weekface mentioned this pull request Aug 22, 2019

tidb-in-kubernetes: add permitHost document pingcap/docs-cn#1777

Merged

fix access denied for root when executing initsql.

383ec54

shonge dismissed stale reviews from weekface and tennix via 383ec54 August 26, 2019 08:30

Merge branch 'master' into init_tidb

7c1803c

weekface previously approved these changes Aug 27, 2019

View reviewed changes

Merge branch 'master' into init_tidb

cd550c7

weekface requested a review from cofyc August 28, 2019 11:07

tennix previously approved these changes Sep 3, 2019

View reviewed changes

cofyc reviewed Sep 3, 2019

View reviewed changes

charts/tidb-cluster/templates/scripts/_initialize_tidb_users.py.tpl Show resolved Hide resolved

delete two duplicate commit lines

fc415df

shonge dismissed stale reviews from tennix and weekface via fc415df September 4, 2019 07:36

Merge branch 'master' into init_tidb

1897232

Merge branch 'master' into init_tidb

c270f55

cofyc approved these changes Sep 9, 2019

View reviewed changes

tennix approved these changes Sep 9, 2019

View reviewed changes

weekface approved these changes Sep 9, 2019

View reviewed changes

cofyc merged commit cfd5f63 into pingcap:master Sep 9, 2019

sre-bot mentioned this pull request Sep 9, 2019

add tidb permit host option (#779) #893

Merged

tennix mentioned this pull request Oct 8, 2019

Restrict accessing host for user in the initializer job #733

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add tidb permit host option #779

add tidb permit host option #779

shonge commented Aug 16, 2019

sre-bot commented Aug 16, 2019

sre-bot commented Aug 16, 2019

CLAassistant commented Aug 16, 2019 •

edited

Loading

weekface commented Aug 16, 2019

tennix left a comment

weekface commented Aug 22, 2019

weekface commented Aug 22, 2019

weekface commented Aug 26, 2019

shonge commented Aug 27, 2019

weekface left a comment

weekface commented Aug 27, 2019

weekface commented Aug 28, 2019

weekface commented Aug 28, 2019

tennix left a comment

weekface commented Sep 4, 2019

weekface commented Sep 4, 2019

cofyc commented Sep 9, 2019

cofyc left a comment

cofyc commented Sep 9, 2019

tennix left a comment

sre-bot commented Sep 9, 2019

cofyc commented Sep 9, 2019

add tidb permit host option #779

add tidb permit host option #779

Conversation

shonge commented Aug 16, 2019

What problem does this PR solve?

What is changed and how does it work?

Check List

Does this PR introduce a user-facing change?:

sre-bot commented Aug 16, 2019

sre-bot commented Aug 16, 2019

CLAassistant commented Aug 16, 2019 • edited Loading

weekface commented Aug 16, 2019

tennix left a comment

Choose a reason for hiding this comment

weekface commented Aug 22, 2019

weekface commented Aug 22, 2019

weekface commented Aug 26, 2019

shonge commented Aug 27, 2019

weekface left a comment

Choose a reason for hiding this comment

weekface commented Aug 27, 2019

weekface commented Aug 28, 2019

weekface commented Aug 28, 2019

tennix left a comment

Choose a reason for hiding this comment

weekface commented Sep 4, 2019

weekface commented Sep 4, 2019

cofyc commented Sep 9, 2019

cofyc left a comment

Choose a reason for hiding this comment

cofyc commented Sep 9, 2019

tennix left a comment

Choose a reason for hiding this comment

sre-bot commented Sep 9, 2019

cofyc commented Sep 9, 2019

CLAassistant commented Aug 16, 2019 •

edited

Loading