Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tidb permit host option (#779) #893

Merged
merged 10 commits into from
Sep 9, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Sep 9, 2019

cherry-pick #779 to release-1.0


What problem does this PR solve?

#733

What is changed and how does it work?

Add an option permitHost in values, and add the logic in _initialize_tidb_users.py.tpl

Check List

Tests

  • Manual test

Code changes

  • Has Helm charts change

Side effects

None

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?:

Users can designate permitting host in chart values.tidb.permitHost

@cofyc cofyc merged commit 1a974b6 into pingcap:release-1.0 Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants