distsql: avoid false positive error log about `invalid cop task execu…

…tion summaries length` (#28188) (#28263)
pingcap · Feb 10, 2022 · 1b2b2e0 · 1b2b2e0
1 parent a424531
commit 1b2b2e0
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/distsql/select_result.go b/distsql/select_result.go
@@ -401,9 +401,14 @@ func (r *selectResult) updateCopRuntimeStats(ctx context.Context, copStats *copr
 	} else {
 		// For cop task cases, we still need this protection.
 		if len(r.selectResp.GetExecutionSummaries()) != len(r.copPlanIDs) {
-			logutil.Logger(ctx).Error("invalid cop task execution summaries length",
-				zap.Int("expected", len(r.copPlanIDs)),
-				zap.Int("received", len(r.selectResp.GetExecutionSummaries())))
+			// for TiFlash streaming call(BatchCop and MPP), it is by design that only the last response will
+			// carry the execution summaries, so it is ok if some responses have no execution summaries, should
+			// not trigger an error log in this case.
+			if !(r.storeType == kv.TiFlash && len(r.selectResp.GetExecutionSummaries()) == 0) {
+				logutil.Logger(ctx).Error("invalid cop task execution summaries length",
+					zap.Int("expected", len(r.copPlanIDs)),
+					zap.Int("received", len(r.selectResp.GetExecutionSummaries())))
+			}
 			return
 		}
 		for i, detail := range r.selectResp.GetExecutionSummaries() {