-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distsql: avoid false positive error log about invalid cop task execution summaries length
(#28188)
#28263
distsql: avoid false positive error log about invalid cop task execution summaries length
(#28188)
#28263
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@windtalker you're already a collaborator in bot's repo. |
/merge |
@windtalker: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 05788e6
|
/run-mysql-test |
cherry-pick #28188 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/28263
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
If TiDB is running query in MPP mode, there may be many error log about
invalid cop task execution summaries length
, it often makes user confused.What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
In fact, for streaming rpc to TiFlash(BatchCop and MPP), it is by design that only the last response will carry the execution summaries, so it is ok if some responses have no execution summaries, should not trigger an error log in this case.
Check List
Tests
Side effects
Documentation
Release note