executor: set the DDL query string instead of execute (#17407) (#17421

)
pingcap · May 26, 2020 · 689a6b6 · 689a6b6
1 parent 682549b
commit 689a6b6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/executor/adapter.go b/executor/adapter.go
@@ -718,6 +718,7 @@ func (a *ExecStmt) buildExecutor() (Executor, error) {
  if err != nil {
  return nil, err
  }
+ a.Ctx.SetValue(sessionctx.QueryString, executorExec.stmt.Text())
  a.OutputNames = executorExec.outputNames
  a.isPreparedStmt = true
  a.Plan = executorExec.plan

diff --git a/session/session_test.go b/session/session_test.go
@@ -314,6 +314,18 @@ func (s *testSessionSuite) TestQueryString(c *C) {
  c.Assert(err, IsNil)
  qs := tk.Se.Value(sessionctx.QueryString)
  c.Assert(qs.(string), Equals, "CREATE TABLE t2(id bigint PRIMARY KEY, age int)")
+
+ // Test execution of DDL through the "Execute" interface.
+ _, err = tk.Se.Execute(context.Background(), "use test;")
+ c.Assert(err, IsNil)
+ _, err = tk.Se.Execute(context.Background(), "drop table t2")
+ c.Assert(err, IsNil)
+ _, err = tk.Se.Execute(context.Background(), "prepare stmt from 'CREATE TABLE t2(id bigint PRIMARY KEY, age int)'")
+ c.Assert(err, IsNil)
+ _, err = tk.Se.Execute(context.Background(), "execute stmt")
+ c.Assert(err, IsNil)
+ qs = tk.Se.Value(sessionctx.QueryString)
+ c.Assert(qs.(string), Equals, "CREATE TABLE t2(id bigint PRIMARY KEY, age int)")
 }
 
 func (s *testSessionSuite) TestAffectedRows(c *C) {