Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: set the DDL query string instead of execute (#17407) #17421

Merged
merged 1 commit into from
May 26, 2020

Conversation

wjhuang2016
Copy link
Member

What problem does this PR solve?

Issue Number: close #17401

Problem Summary:
We didn't set the DDL query string properly. In an EXECUTE statement, we need to use the DDL query string we executing, not the execute query string.

What is changed and how it works?

Proposal: xxx

If the executor is an ExecuteExec, we set the query string to the real query string.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

Release note

  • Fix a bug that records the wrong query for the DDL statement within the EXECUTE statement.

@wjhuang2016 wjhuang2016 requested a review from a team as a code owner May 26, 2020 09:03
@ghost ghost requested review from SunRunAway and removed request for a team May 26, 2020 09:03
@wjhuang2016 wjhuang2016 added priority/release-blocker This issue blocks a release. Please solve it ASAP. type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels May 26, 2020
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the sig/execution SIG execution label May 26, 2020
@jebter
Copy link

jebter commented May 26, 2020

/merge

2 similar comments
@jebter
Copy link

jebter commented May 26, 2020

/merge

@jebter
Copy link

jebter commented May 26, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 26, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 26, 2020

/run-all-tests

@sre-bot sre-bot merged commit 689a6b6 into pingcap:release-4.0 May 26, 2020
@wjhuang2016 wjhuang2016 deleted the release-4.0 branch November 17, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants