lightning: enable nogo checks for restore-opts (#37615)

close #37614
pingcap · Sep 5, 2022 · 6b8cf9d · 6b8cf9d
1 parent 80841ac
commit 6b8cf9d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/br/pkg/lightning/restore/opts/precheck_opts.go b/br/pkg/lightning/restore/opts/precheck_opts.go
@@ -16,19 +16,27 @@ package opts
 
 import "github.com/pingcap/tidb/br/pkg/lightning/mydump"
 
+// PrecheckItemBuilderConfig defines the config used in a precheck builder,
+// which affects the behavior for executing precheck items.
 type PrecheckItemBuilderConfig struct {
  PreInfoGetterOptions []GetPreInfoOption
  MDLoaderSetupOptions []mydump.MDLoaderSetupOption
 }
 
+// PrecheckItemBuilderOption defines the options when constructing a precheck builder,
+// which affects the behavior for executing precheck items.
 type PrecheckItemBuilderOption func(c *PrecheckItemBuilderConfig)
 
+// WithPreInfoGetterOptions generates a precheck item builder option
+// to control the get pre info behaviors.
 func WithPreInfoGetterOptions(opts ...GetPreInfoOption) PrecheckItemBuilderOption {
  return func(c *PrecheckItemBuilderConfig) {
  c.PreInfoGetterOptions = append([]GetPreInfoOption{}, opts...)
  }
 }
 
+// WithMDLoaderSetupOptions generates a precheck item builder option
+// to control the mydumper loader setup behaviors.
 func WithMDLoaderSetupOptions(opts ...mydump.MDLoaderSetupOption) PrecheckItemBuilderOption {
  return func(c *PrecheckItemBuilderConfig) {
  c.MDLoaderSetupOptions = append([]mydump.MDLoaderSetupOption{}, opts...)

diff --git a/build/nogo_config.json b/build/nogo_config.json
@@ -198,6 +198,7 @@
  },
  "only_files": {
  "br/pkg/lightning/mydump/": "br/pkg/lightning/mydump/",
+ "br/pkg/lightning/restore/opts": "br/pkg/lightning/restore/opts",
  "executor/aggregate.go": "executor/aggregate.go",
  "types/json/binary_functions.go": "types/json/binary_functions.go",
  "types/json/binary_test.go": "types/json/binary_test.go",
@@ -324,6 +325,7 @@
  },
  "only_files": {
  "br/pkg/lightning/mydump/": "br/pkg/lightning/mydump/",
+ "br/pkg/lightning/restore/opts": "br/pkg/lightning/restore/opts",
  "kv/": "kv code",
  "util/memory": "util/memory",
  "ddl/": "ddl",
@@ -351,6 +353,7 @@
  },
  "only_files": {
  "br/pkg/lightning/mydump/": "br/pkg/lightning/mydump/",
+ "br/pkg/lightning/restore/opts": "br/pkg/lightning/restore/opts",
  "executor/aggregate.go": "executor/aggregate.go",
  "types/json/binary_functions.go": "types/json/binary_functions.go",
  "types/json/binary_test.go": "types/json/binary_test.go",
@@ -713,6 +716,7 @@
  },
  "only_files": {
  "br/pkg/lightning/mydump/": "br/pkg/lightning/mydump/",
+ "br/pkg/lightning/restore/opts": "br/pkg/lightning/restore/opts",
  "executor/aggregate.go": "executor/aggregate.go",
  "types/json/binary_functions.go": "types/json/binary_functions.go",
  "types/json/binary_test.go": "types/json/binary_test.go",