Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lightning: Enable more Nogo Checks for Restore Opts Package #37614

Closed
dsdashun opened this issue Sep 5, 2022 · 1 comment · Fixed by #37615
Closed

Lightning: Enable more Nogo Checks for Restore Opts Package #37614

dsdashun opened this issue Sep 5, 2022 · 1 comment · Fixed by #37615
Labels
component/lightning This issue is related to Lightning of TiDB. type/enhancement The issue or PR belongs to an enhancement.

Comments

@dsdashun
Copy link
Contributor

dsdashun commented Sep 5, 2022

Enhancement

Restore opts package is a new package. We need to apply more no-go checks to it, to improve the code quality.
@dsdashun dsdashun added the type/enhancement The issue or PR belongs to an enhancement. label Sep 5, 2022
@dsdashun
Copy link
Contributor Author

dsdashun commented Sep 5, 2022

/component lightning

@ti-chi-bot ti-chi-bot added the component/lightning This issue is related to Lightning of TiDB. label Sep 5, 2022
@dsdashun dsdashun mentioned this issue Sep 5, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Sep 5, 2022
@dsdashun
lightning: enable nogo checks for restore-opts (#37615)
6b8cf9d 
close #37614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/lightning This issue is related to Lightning of TiDB. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lightning: enable nogo checks for restore-opts dsdashun/tidb
2 participants
@dsdashun @ti-chi-bot