Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Planner: support index advisor - Phase 1 #12303

Closed
zz-jason opened this issue Sep 23, 2019 · 3 comments
Closed

Planner: support index advisor - Phase 1 #12303

zz-jason opened this issue Sep 23, 2019 · 3 comments
Assignees
@eurekaka
Labels
feature/accepted This feature request is accepted by product managers priority/P2 The issue has P2 priority. sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement. type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@zz-jason
Copy link
Member

zz-jason commented Sep 23, 2019 •
edited
Loading

Description

Some basic functionality:

  • advising about removing an unused index.
  • advising about adding an index that improves the query performance.

Category

  • Feature
  • Performance
  • Usability

Value

Value Description

Makes TiDB easier to use, reduces the SQL Tunning time during the application testing phase.

Value Score

Optional value: 1~5

  • 4

Workload Estimation

Workload contains coding, documenting, and testing.
1 Point for 1 Person/Work Day

  • 45 Points
@zz-jason zz-jason added the type/enhancement The issue or PR belongs to an enhancement. label Sep 23, 2019
@alivxxx
Copy link
Contributor

alivxxx commented Oct 17, 2019

Currently we are discussing the feature at #wg-index-advisor of community slack, feel free to join and discuss the design docs and working plan there.

@winoros winoros mentioned this issue Feb 3, 2020
Open
@zz-jason zz-jason added sig/planner SIG: Planner type/feature-request Categorizes issue or PR as related to a new feature. labels May 28, 2020
@zz-jason zz-jason changed the title feature request: an index advisor support index advisor May 28, 2020
@scsldb scsldb added the priority/P2 The issue has P2 priority. label Jun 15, 2020
@zz-jason
Copy link
Member Author

With the system view described in #17508, we can know the unused index for each table.

@zz-jason zz-jason added the feature/accepted This feature request is accepted by product managers label Jul 29, 2020
@qw4990 qw4990 closed this as completed Aug 29, 2024
@qw4990 qw4990 reopened this Aug 29, 2024
@qw4990
Copy link
Contributor

qw4990 commented Sep 3, 2024 •
edited
Loading

The new design and implementation, please see
https://github.com/pingcap/tidb_workload_analysis/tree/main/index_advisor.
I'll try to integrate this feature into the Kernel.

This was referenced Sep 3, 2024
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Sep 4, 2024
@qw4990
planner: remove old useless unfinished index advisor implementation (#…
2bd5660 
…55810)

ref #12303
ti-chi-bot bot pushed a commit that referenced this issue Sep 4, 2024
@qw4990
planner: move index advisor into the kernel (#55820)
e00454a 
ref #12303
@qw4990 qw4990 mentioned this issue Sep 5, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Sep 5, 2024
@qw4990
planner: move index advisor into the kernel (#55874)
e9124dd 
ref #12303
@qw4990 qw4990 mentioned this issue Sep 9, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Sep 10, 2024
@qw4990
planner: support new syntax for Index Advisor (#55947)
822bf99 
ref #12303
@qw4990 qw4990 mentioned this issue Sep 19, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Sep 20, 2024
@qw4990
planner: support loading queries from statement_summary to run Index …
6b44ed4 
…Advisor (#56160)

ref #12303
@qw4990 qw4990 mentioned this issue Sep 20, 2024
Merged
13 tasks
winoros pushed a commit to winoros/tidb that referenced this issue Sep 23, 2024
@qw4990 @winoros
planner: support loading queries from statement_summary to run Index …
076fe76 
…Advisor (pingcap#56160)

ref pingcap#12303
ti-chi-bot bot pushed a commit that referenced this issue Sep 23, 2024
@qw4990
planner: add a new sys table to store index advisor results and a new…
8106d93 
… table to store kernel options (#56188)

ref #12303
@qw4990 qw4990 mentioned this issue Sep 24, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Sep 24, 2024
@qw4990
planner: support recommend index set <opt>=<val> (#56249)
281462c 
ref #12303
@qw4990 qw4990 mentioned this issue Sep 24, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Sep 25, 2024
@qw4990
planner: support recommend index show to show all options (#56268)
fd38012 
ref #12303
@qw4990 qw4990 mentioned this issue Sep 25, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Sep 25, 2024
@qw4990
planner: support using with <opt>=<val> to set options when running…
59a8acb 
… index advisor (#56307)

ref #12303
@qw4990 qw4990 mentioned this issue Sep 26, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Sep 26, 2024
@qw4990
planner: more test cases for index advisor (#56334)
d7ba47b 
ref #12303
@qw4990 qw4990 mentioned this issue Oct 10, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 10, 2024
@qw4990
planner: add TPCC as a test case for index advisor (#56528)
329af09 
ref #12303
@qw4990 qw4990 mentioned this issue Oct 29, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 29, 2024
@qw4990
planner: convert schema_name from NULL to "" for index advisor (#56943)
a9c9208 
ref #12303
This was referenced Dec 16, 2024
Merged
Merged
@qw4990 qw4990 changed the title support index advisor Planner: support index advisor - Phase 1 Dec 16, 2024
@qw4990 qw4990 closed this as completed Dec 16, 2024
ti-chi-bot bot pushed a commit that referenced this issue Dec 16, 2024
@qw4990
planner: remove useless test files of Index Advisor (#58294)
9ffbcaf 
ref #12303
ti-chi-bot bot pushed a commit that referenced this issue Dec 16, 2024
@qw4990
planner: output create-index statements for recommend index run (#5…
57a73ea 
…8293)

ref #12303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eurekaka eurekaka

Labels
feature/accepted This feature request is accepted by product managers priority/P2 The issue has P2 priority. sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement. type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@zz-jason @scsldb @eurekaka @qw4990 @alivxxx