planner: add a new sys table to store index advisor results and a new table to store kernel options #56188

qw4990 · 2024-09-20T08:03:51Z

What problem does this PR solve?

Issue Number: ref #12303

Problem Summary: planner: add a new sys table to store index advisor results

What changed and how does it work?

CREATE TABLE IF NOT EXISTS mysql.index_advisor_results (
       id bigint primary key not null auto_increment,
       created_at timestamp not null,
       updated_at timestamp not null,
       schema_name varchar(64) not null,
       table_name varchar(64) not null,
       index_name varchar(127) not null,
       index_columns varchar(500) not null COMMENT 'split by ",", e.g. "c1", "c1,c2", "c1,c2,c3,c4,c5"',
       index_details json,        -- est_index_size, reason, DDL to create this index, ...
       top_impacted_queries json, -- improvement, plan before and after this index, ...
       workload_impact json,      -- improvement and more details, ...
       extra json,                -- for the cloud env to save more info like RU, cost_saving, ...
       index idx_create(created_at),
       index idx_update(updated_at),
       unique index idx(schema_name, table_name, index_columns))

CREATE TABLE IF NOT EXISTS mysql.tidb_kernel_options (
        module varchar(128),
        name varchar(128),
        value varchar(128),
        updated_at datetime,
        status varchar(128),
        description text,
        primary key(module, name))

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2024-09-20T08:04:06Z

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2024-09-20T08:25:15Z

Codecov Report

Attention: Patch coverage is 68.08511% with 15 lines in your changes missing coverage. Please review.

Project coverage is 76.2376%. Comparing base (d55808c) to head (477cdbb).
Report is 8 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #56188        +/-   ##
================================================
+ Coverage   73.4698%   76.2376%   +2.7677%     
================================================
  Files          1600       1622        +22     
  Lines        443771     453528      +9757     
================================================
+ Hits         326038     345759     +19721     
+ Misses        97754      86421     -11333     
- Partials      19979      21348      +1369

Flag	Coverage Δ
integration	`52.3807% <8.5106%> (?)`
unit	`72.7221% <68.0851%> (+0.1870%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9478% <ø> (-0.0089%)`	⬇️
parser	`∅ <ø> (∅)`
br	`63.0788% <ø> (+17.2161%)`	⬆️

qw4990 · 2024-09-20T08:38:19Z

/retest

tiprow · 2024-09-20T08:38:41Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qw4990 · 2024-09-20T09:21:16Z

/test unit-test

tiprow · 2024-09-20T09:21:38Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2024-09-20T09:25:24Z

[LGTM Timeline notifier]

Timeline:

2024-09-20 08:19:13.545934818 +0000 UTC m=+1208423.286358754: ☑️ agreed by hawkingrei.
2024-09-20 09:25:23.297966782 +0000 UTC m=+1212393.038390723: ☑️ agreed by AilinKid.

Benjamin2037

LGTM

qw4990 · 2024-09-23T01:17:20Z

/test unit-test

tiprow · 2024-09-23T01:17:43Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

yudongusa

LGTM

D3Hunter · 2024-09-23T02:30:24Z

pkg/session/bootstrap.go

+       extra json,                -- for the cloud env to save more info like RU, cost_saving, ...
+       index idx_create(created_at),
+       index idx_update(updated_at),
+       unique index idx(schema_name, table_name, index_columns))`


if a table dropped and add same index using advisor again, will it conflict?

Maybe, but we'll use insert ... on duplicate ... to update this table to make sure there is only one record for an unique index.

ti-chi-bot · 2024-09-23T03:48:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, AilinKid, Benjamin2037, D3Hunter, hawkingrei, XuHuaiyu, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [3pointer,AilinKid,Benjamin2037,D3Hunter,XuHuaiyu,hawkingrei]
~~br/OWNERS~~ [3pointer]
~~pkg/ddl/OWNERS~~ [Benjamin2037,D3Hunter]
~~pkg/executor/importer/OWNERS~~ [D3Hunter]
~~pkg/expression/OWNERS~~ [XuHuaiyu]
~~pkg/planner/OWNERS~~ [AilinKid,hawkingrei]
~~pkg/session/OWNERS~~ [yudongusa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hawkingrei · 2024-09-23T05:35:53Z

/ok-to-test

qw4990 · 2024-09-23T06:11:36Z

/test unit-test

tiprow · 2024-09-23T06:11:56Z

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qw4990 · 2024-09-23T06:56:56Z

/test unit-test

tiprow · 2024-09-23T06:57:19Z

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qw4990 · 2024-09-23T07:38:12Z

/hold

qw4990 · 2024-09-23T08:31:30Z

/unhold

qw4990 · 2024-09-23T09:51:32Z

/test unit-test

tiprow · 2024-09-23T09:51:53Z

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qw4990 · 2024-09-23T12:22:53Z

/test unit-test

tiprow · 2024-09-23T12:23:16Z

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qw4990 · 2024-09-23T15:18:54Z

/test unit-test

tiprow · 2024-09-23T15:19:18Z

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qw4990 added 3 commits September 20, 2024 15:56

fixup

ed9e98c

fixup

95e6d78

fixup

3e77c5c

ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Sep 20, 2024

fixup

72c2d3b

hawkingrei approved these changes Sep 20, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 20, 2024

AilinKid approved these changes Sep 20, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 20, 2024

fixup

e46bfef

Benjamin2037 approved these changes Sep 21, 2024

View reviewed changes

yudongusa approved these changes Sep 23, 2024

View reviewed changes

fixup

e27f391

D3Hunter approved these changes Sep 23, 2024

View reviewed changes

fixup

cc3c810

3pointer approved these changes Sep 23, 2024

View reviewed changes

ti-chi-bot bot added the approved label Sep 23, 2024

fixup

0ff5606

qw4990 added 3 commits September 23, 2024 11:53

fixup

0e6251e

fixup

e73242f

fixup

7630f72

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 23, 2024

fixup

c31a123

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2024

qw4990 added 4 commits September 23, 2024 16:01

Merge remote-tracking branch 'upstream/master' into index-advisor-demo-2

6ee3b22

fixup

532e133

fixup

37f7459

fixup

a794646

ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2024

qw4990 changed the title ~~planner: add a new sys table to store index advisor results~~ planner: add a new sys table to store index advisor results and a new table to store kernel options Sep 23, 2024

fixup

477cdbb

ti-chi-bot bot merged commit 8106d93 into pingcap:master Sep 23, 2024
18 of 25 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

planner: add a new sys table to store index advisor results and a new table to store kernel options #56188

planner: add a new sys table to store index advisor results and a new table to store kernel options #56188

qw4990 commented Sep 20, 2024 •

edited

Loading

tiprow bot commented Sep 20, 2024

codecov bot commented Sep 20, 2024 •

edited

Loading

qw4990 commented Sep 20, 2024

tiprow bot commented Sep 20, 2024

qw4990 commented Sep 20, 2024

tiprow bot commented Sep 20, 2024

ti-chi-bot bot commented Sep 20, 2024

Benjamin2037 left a comment

qw4990 commented Sep 23, 2024

tiprow bot commented Sep 23, 2024

yudongusa left a comment

D3Hunter Sep 23, 2024

qw4990 Sep 23, 2024

ti-chi-bot bot commented Sep 23, 2024

hawkingrei commented Sep 23, 2024

qw4990 commented Sep 23, 2024

tiprow bot commented Sep 23, 2024

qw4990 commented Sep 23, 2024

tiprow bot commented Sep 23, 2024

qw4990 commented Sep 23, 2024

qw4990 commented Sep 23, 2024

qw4990 commented Sep 23, 2024

tiprow bot commented Sep 23, 2024

qw4990 commented Sep 23, 2024

tiprow bot commented Sep 23, 2024

qw4990 commented Sep 23, 2024

tiprow bot commented Sep 23, 2024

planner: add a new sys table to store index advisor results and a new table to store kernel options #56188

planner: add a new sys table to store index advisor results and a new table to store kernel options #56188

Conversation

qw4990 commented Sep 20, 2024 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

tiprow bot commented Sep 20, 2024

codecov bot commented Sep 20, 2024 • edited Loading

Codecov Report

qw4990 commented Sep 20, 2024

tiprow bot commented Sep 20, 2024

qw4990 commented Sep 20, 2024

tiprow bot commented Sep 20, 2024

ti-chi-bot bot commented Sep 20, 2024

[LGTM Timeline notifier]

Benjamin2037 left a comment

Choose a reason for hiding this comment

qw4990 commented Sep 23, 2024

tiprow bot commented Sep 23, 2024

yudongusa left a comment

Choose a reason for hiding this comment

D3Hunter Sep 23, 2024

Choose a reason for hiding this comment

qw4990 Sep 23, 2024

Choose a reason for hiding this comment

ti-chi-bot bot commented Sep 23, 2024

hawkingrei commented Sep 23, 2024

qw4990 commented Sep 23, 2024

tiprow bot commented Sep 23, 2024

qw4990 commented Sep 23, 2024

tiprow bot commented Sep 23, 2024

qw4990 commented Sep 23, 2024

qw4990 commented Sep 23, 2024

qw4990 commented Sep 23, 2024

tiprow bot commented Sep 23, 2024

qw4990 commented Sep 23, 2024

tiprow bot commented Sep 23, 2024

qw4990 commented Sep 23, 2024

tiprow bot commented Sep 23, 2024

qw4990 commented Sep 20, 2024 •

edited

Loading

codecov bot commented Sep 20, 2024 •

edited

Loading