Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible with mysql 5.7 noop variables: innodb_default_row_format #23541

Closed
King-Dylan opened this issue Mar 25, 2021 · 4 comments · Fixed by #23568
Closed

Compatible with mysql 5.7 noop variables: innodb_default_row_format #23541

King-Dylan opened this issue Mar 25, 2021 · 4 comments · Fixed by #23568
Assignees
Labels
sig/sql-infra SIG: SQL Infra type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@King-Dylan
Copy link
Contributor

Feature Request

Compatible with mysql 8.0 parameter innodb_default_row_format

Is your feature request related to a problem? Please describe:
jira is required for innodb_default_row_format = dynamic

Describe the feature you'd like:
user can set innodb_default_row_format and can use set variables change value

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

@King-Dylan King-Dylan added the type/feature-request Categorizes issue or PR as related to a new feature. label Mar 25, 2021
@djshow832
Copy link
Contributor

As the row format is not suitable for TiKV, does it mean TiDB can allow users to set its value and just ignore it?

@King-Dylan
Copy link
Contributor Author

As the row format is not suitable for TiKV, does it mean TiDB can allow users to set its value and just ignore it?

yes

@djshow832 djshow832 added the sig/sql-infra SIG: SQL Infra label Mar 25, 2021
@morgo morgo self-assigned this Mar 26, 2021
@morgo
Copy link
Contributor

morgo commented Mar 26, 2021

I agree in this instance it is fine to ignore. What JIRA is doing is a little bit silly:

  • innodb_default_row_format was introduced in 5.7 where the default is DYNAMIC. Prior to this, you needed to specify the row format per-table (and at that time it defaulted to compact)
  • JIRA is setting it to DYNAMIC, very likely to ensure that indexes on varchar(255) + utf8mb4 are supported. So it is essentially only handling the case that a user might change the default (users rarely would).

@morgo morgo changed the title Compatible with mysql 8.0 sysvariables: innodb_default_row_format Compatible with mysql 5.7 noop variables: innodb_default_row_format Mar 26, 2021
@morgo
Copy link
Contributor

morgo commented Mar 26, 2021

@King-Dylan I have a PR available to fix this, but I've not tagged it for cherry picking to a release branch. Let's chat on Feishu/Slack if you would like it to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants