-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sessionctx: change innodb large prefix default (#24555) #25687
sessionctx: change innodb large prefix default (#24555) #25687
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@wjhuang2016 @xhebox this is now ready for review. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6f255a6
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #24555 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/25687
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Problem Summary:
I received more details about #23541 and it looks like the original PR did not change a required setting according to this blog post: https://nova.moe/run-jira-on-tidb/
What is changed and how it works?
What's Changed:
The default for a noop variable changes. It is safe to do this, since the TiDB behavior reflects the 'on' state.
Related changes
Check List
Tests
Side effects
Release note