-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
variable: Add innodb_default_row_format as noop #23568
variable: Add innodb_default_row_format as noop #23568
Conversation
/lgtm |
/run-check_dev_2 |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zz-jason: Please use If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: fb00bfc
|
/run-unit-test |
/run-unit-test |
@morgo: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: fixes #23541
Problem Summary:
JIRA needs to be able to set
innodb_default_row_format
to function correctly. This adds it as a noop, which is safe to be able to do.The
innodb_file_format
is also changed to be Barracuda, because Dynamic is only possible with Barracuda. Barracuda is also the default in MySQL 5.7, and file_formats become obsolete in MySQL 8.0.What is changed and how it works?
What's Changed:
A noop sysvar was added:
innodb_default_row_format
.Related changes
Check List
Tests
Side effects
Release note
innodb_default_row_format
was added for compatibility with Jira. Setting it has no effect.