Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leak test in TestPrepareTableAsNameOnGroupByWithCache #25394

Closed
zhouqiang-cl opened this issue Jun 14, 2021 · 2 comments
Closed

Leak test in TestPrepareTableAsNameOnGroupByWithCache #25394

zhouqiang-cl opened this issue Jun 14, 2021 · 2 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug.

Comments

@zhouqiang-cl
Copy link
Contributor

Bug Report

[2021-06-14T12:17:45.562Z] FAIL: prepare_test.go:304: testPrepareSerialSuite.TestPrepareTableAsNameOnGroupByWithCache

[2021-06-14T12:17:45.562Z] 

[2021-06-14T12:17:45.562Z] prepare_test.go:343:

[2021-06-14T12:17:45.562Z]     ...

[2021-06-14T12:17:45.562Z] /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/util/testleak/leaktest.go:168:

[2021-06-14T12:17:45.562Z]     c.Errorf("Test %s check-count %d appears to have leaked: %v", c.TestName(), cnt, g)

[2021-06-14T12:17:45.562Z] ... Error: Test testPrepareSerialSuite.TestPrepareTableAsNameOnGroupByWithCache check-count 50 appears to have leaked: github.com/pingcap/tidb/domain.(*Domain).globalBindHandleWorkerLoop.func1(0xc31d4214a0)

[2021-06-14T12:17:45.562Z] 	/home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/domain/domain.go:1005 +0x12a

[2021-06-14T12:17:45.562Z] created by github.com/pingcap/tidb/domain.(*Domain).globalBindHandleWorkerLoop

[2021-06-14T12:17:45.562Z] 	/home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/domain/domain.go:996 +0x5f

[2021-06-14T12:17:45.562Z] 

[2021-06-14T12:17:45.562Z] OOPS: 363 passed, 1 FAILED

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

in ci https://ci.pingcap.net/blue/organizations/jenkins/tidb-unit-test-nightly/detail/tidb-unit-test-nightly/644/pipeline

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

master a45b3aa

@zhouqiang-cl zhouqiang-cl added type/bug The issue is confirmed as a bug. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 14, 2021
@qw4990
Copy link
Contributor

qw4990 commented Aug 4, 2021

Seems to be fixed by #26500. I'll close it now, if it appears again, please reopen it.

@qw4990 qw4990 closed this as completed Aug 4, 2021
@ti-srebot
Copy link
Contributor

Please edit this comment or add a new comment to complete the following information

Not a bug

  1. Remove the 'type/bug' label
  2. Add notes to indicate why it is not a bug

Duplicate bug

  1. Add the 'type/duplicate' label
  2. Add the link to the original bug

Bug

Note: Make Sure that 'component', and 'severity' labels are added
Example for how to fill out the template: #20100

1. Root Cause Analysis (RCA) (optional)

2. Symptom (optional)

3. All Trigger Conditions (optional)

4. Workaround (optional)

5. Affected versions

6. Fixed versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

4 participants