Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix goroutine leak problem in some unit tests #26500

Merged
merged 3 commits into from
Jul 23, 2021
Merged

planner: fix goroutine leak problem in some unit tests #26500

merged 3 commits into from
Jul 23, 2021

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jul 23, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #25014, #25190

Problem Summary: planner: fix goroutine leak problem in some unit tests

What is changed and how it works?

planner: fix goroutine leak problem in some unit tests

Check List

Tests

  • Unit test

Release note

  • No release note

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 23, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2021
@wjhuang2016
Copy link
Member

Please close #25190 too

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 23, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jul 23, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 548668e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 23, 2021
@ti-chi-bot ti-chi-bot merged commit 591ebdd into pingcap:master Jul 23, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 23, 2021
@qw4990 @ti-srebot
cherry pick pingcap#26500 to release-4.0
63b266b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 23, 2021
Closed
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #26503

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 23, 2021
@qw4990 @ti-srebot
cherry pick pingcap#26500 to release-5.0
5ff723f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 23, 2021
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #26505

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 23, 2021
@qw4990 @ti-srebot
cherry pick pingcap#26500 to release-5.1
26178f0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 23, 2021
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #26506

@qw4990 qw4990 mentioned this pull request Aug 4, 2021
Closed
@qw4990 qw4990 mentioned this pull request Aug 18, 2021
Merged
1 task
ti-chi-bot pushed a commit that referenced this pull request Sep 16, 2021
@ti-srebot
planner: fix goroutine leak problem in some unit tests (#26500) (#26506)
1cae2c5
ti-chi-bot pushed a commit that referenced this pull request Dec 17, 2021
@ti-srebot
planner: fix goroutine leak problem in some unit tests (#26500) (#26505)
45ecc71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent approved these changes

@winoros winoros winoros approved these changes

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unstable test FAIL: prepare_test.go:448: testPrepareSerialSuite.TestPrepareCacheForPartition
6 participants
@qw4990 @wjhuang2016 @ti-chi-bot @ti-srebot @winoros @Reminiscent