Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: need to optimize communication with tikv stores. #31722

Closed
3pointer opened this issue Jan 17, 2022 · 0 comments · Fixed by #35147
Closed

br: need to optimize communication with tikv stores. #31722

3pointer opened this issue Jan 17, 2022 · 0 comments · Fixed by #35147
Assignees
@joccau
Labels
component/br This issue is related to BR of TiDB. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@3pointer
Copy link
Contributor

3pointer commented Jan 17, 2022 •
edited
Loading

Enhancement

There are some references about GetAllTiKVStores.

	allStores, err := conn.GetAllTiKVStores(ctx, pdClient, conn.SkipTiFlash)
	for _, s := range allStores {
            ...
        }

this not efficient when meet a cluster has lots of available stores. it's better to use goroutine wait group to reduce the time costs and add an united retry logic.
@3pointer 3pointer added type/enhancement The issue or PR belongs to an enhancement. component/br This issue is related to BR of TiDB. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jan 17, 2022
@3pointer 3pointer assigned 3pointer and joccau and unassigned 3pointer Jan 21, 2022
MoCuishle28 added a commit to MoCuishle28/tidb that referenced this issue Jun 5, 2022
@MoCuishle28
br: optimize communication with tikv stores. pingcap#31722
719fe02 
Signed-off-by: Gaoming Zhang <zhanggaoming028@gmail.com>
@MoCuishle28 MoCuishle28 mentioned this issue Jun 5, 2022
Merged
12 tasks
MoCuishle28 added a commit to MoCuishle28/tidb that referenced this issue Jun 10, 2022
@MoCuishle28
br: optimize communication with tikv stores. pingcap#31722
aa0aed2 
Signed-off-by: Gaoming Zhang <zhanggaoming028@gmail.com>
MoCuishle28 added a commit to MoCuishle28/tidb that referenced this issue Jun 12, 2022
@MoCuishle28
br: optimize communication with tikv stores (pingcap#31722)
5e8dd53 
Signed-off-by: Gaoming Zhang <zhanggaoming028@gmail.com>
MoCuishle28 added a commit to MoCuishle28/tidb that referenced this issue Jun 28, 2022
@MoCuishle28
br: optimize communication with tikv stores (pingcap#31722)
d225fe9 
Signed-off-by: Gaoming Zhang <zhanggaoming028@gmail.com>
MoCuishle28 added a commit to MoCuishle28/tidb that referenced this issue Jun 28, 2022
@MoCuishle28
br: optimize communication with tikv stores. (pingcap#31722)
36b55d6 
Signed-off-by: Gaoming Zhang <zhanggaoming028@gmail.com>
ti-chi-bot pushed a commit that referenced this issue Jul 5, 2022
@MoCuishle28
br: optimize communication with tikv stores. #31722 (#35147)
d8dbab2 
close #31722
morgo added a commit to morgo/tidb that referenced this issue Jul 6, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into improve-skip-init
10c7409 
* upstream/master: (77 commits)
  infoschema: add a simply store for DM's SchemaTracker (pingcap#35954)
  planner: refactor "access object" related logic and prepare for binary plan (pingcap#35890)
  telemetry: Initialize telemetry asynchronously (pingcap#35898)
  sessionctx/variable: convert TiDBLogFileMaxDays and TiDBConfig to ScopeInstance (pingcap#35733)
  session, sessionctx/variable: ensure sysvars are always in lower case (pingcap#35659)
  *: add telemetry support for multi-schema change (pingcap#35977)
  topsql: compress plan instead of dropping it (pingcap#35973)
  *: use pdqsort to improve sort performance (pingcap#34404)
  ddl: refine GetDDLInfo function (pingcap#35969)
  *: Make the code cleaner in session.ExecutePreparedStmt (pingcap#35943)
  ddl: remove `onDropIndexes` (pingcap#35960)
  ddl: refine history job code (pingcap#35967)
  sessionctx,kv,planner: add system variable for fine_grained_shuffle (pingcap#35256)
  *: change remote cache (pingcap#35968)
  *: enable gosec (pingcap#35873)
  plancodec: fix a miss case in conversion (pingcap#35957)
  ddl: support drop indexes for multi-schema change (pingcap#35883)
  pdutil: fix unstable test TestPauseSchedulersByKeyRange (pingcap#35949)
  br: optimize communication with tikv stores. pingcap#31722 (pingcap#35147)
  txn: rename snapshot related methods in txnManager. (pingcap#35912)
  ...
@3pointer 3pointer mentioned this issue Jul 14, 2022
Draft
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joccau joccau

Labels
component/br This issue is related to BR of TiDB. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

br: optimize communication with tikv stores. #31722 MoCuishle28/tidb
2 participants
@3pointer @joccau