Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdutil: fix unstable test TestPauseSchedulersByKeyRange #35949

Merged
merged 2 commits into from
Jul 5, 2022
Merged

pdutil: fix unstable test TestPauseSchedulersByKeyRange #35949

merged 2 commits into from
Jul 5, 2022

Conversation

sleepymole
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #35947

Problem Summary:
The client assumed CreateOrUpdateRegionLabelRule is canceled and sent DeleteRegionLabelRule request.
However server might have received the previous canceled request and process done after the DeleteRegionLabelRule request.

What is changed and how it works?

Add a Mutex to server handler.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 5, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • buchuitoudegou
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 5, 2022
@sleepymole sleepymole marked this pull request as ready for review July 5, 2022 06:27
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2022
@sleepymole sleepymole added the component/lightning This issue is related to Lightning of TiDB. label Jul 5, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 5, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 5, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/311e3446d5dc2751b05aa68f41e4370e1ab4bb52

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 5, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 5, 2022
@sleepymole
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: da34e16

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 5, 2022
@hawkingrei
Copy link
Member

/run-mysql-test
/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit ff7c120 into pingcap:master Jul 5, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 5, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🟥 failed 1, success 11, total 12 13 min New failing
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 1, success 10, total 11 22 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 35 tests passed 27 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 33 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 24 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 9 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 55 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 39 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 4 min 38 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@D3Hunter D3Hunter mentioned this pull request Jul 5, 2022
Merged
12 tasks
@sleepymole sleepymole deleted the issue-35947 branch July 5, 2022 10:17
morgo added a commit to morgo/tidb that referenced this pull request Jul 6, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into improve-skip-init
10c7409 
* upstream/master: (77 commits)
  infoschema: add a simply store for DM's SchemaTracker (pingcap#35954)
  planner: refactor "access object" related logic and prepare for binary plan (pingcap#35890)
  telemetry: Initialize telemetry asynchronously (pingcap#35898)
  sessionctx/variable: convert TiDBLogFileMaxDays and TiDBConfig to ScopeInstance (pingcap#35733)
  session, sessionctx/variable: ensure sysvars are always in lower case (pingcap#35659)
  *: add telemetry support for multi-schema change (pingcap#35977)
  topsql: compress plan instead of dropping it (pingcap#35973)
  *: use pdqsort to improve sort performance (pingcap#34404)
  ddl: refine GetDDLInfo function (pingcap#35969)
  *: Make the code cleaner in session.ExecutePreparedStmt (pingcap#35943)
  ddl: remove `onDropIndexes` (pingcap#35960)
  ddl: refine history job code (pingcap#35967)
  sessionctx,kv,planner: add system variable for fine_grained_shuffle (pingcap#35256)
  *: change remote cache (pingcap#35968)
  *: enable gosec (pingcap#35873)
  plancodec: fix a miss case in conversion (pingcap#35957)
  ddl: support drop indexes for multi-schema change (pingcap#35883)
  pdutil: fix unstable test TestPauseSchedulersByKeyRange (pingcap#35949)
  br: optimize communication with tikv stores. pingcap#31722 (pingcap#35147)
  txn: rename snapshot related methods in txnManager. (pingcap#35912)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buchuitoudegou buchuitoudegou buchuitoudegou approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
component/lightning This issue is related to Lightning of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lightning: unstable test TestPauseSchedulersByKeyRange
5 participants
@sleepymole @ti-chi-bot @sre-bot @hawkingrei @buchuitoudegou