Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DATA RACE in the TestCheckFailReport #32294

Closed
hawkingrei opened this issue Feb 12, 2022 · 1 comment · Fixed by #32295
Closed

DATA RACE in the TestCheckFailReport #32294

hawkingrei opened this issue Feb 12, 2022 · 1 comment · Fixed by #32295
Labels
affects-5.0 This bug affects 5.0.x versions. affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. component/test severity/major type/bug The issue is confirmed as a bug.

Comments

@hawkingrei
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

==================
WARNING: DATA RACE
Write at 0x00c001990800 by goroutine 59:
  github.com/pingcap/tidb/sessionctx/variable.(*SessionVars).SetStatusFlag()
      /go/tidb/sessionctx/variable/session.go:1470 +0x4f8
  github.com/pingcap/tidb/sessionctx/variable.(*SessionVars).SetInTxn()
      /go/tidb/sessionctx/variable/session.go:1481 +0x4c3
  github.com/pingcap/tidb/session.(*session).RollbackTxn()
      /go/tidb/session/session.go:984 +0x49d
  github.com/pingcap/tidb/session.autoCommitAfterStmt()
      /go/tidb/session/tidb.go:261 +0x365
  github.com/pingcap/tidb/session.finishStmt()
      /go/tidb/session/tidb.go:238 +0x3ab
  github.com/pingcap/tidb/session.runStmt()
      /go/tidb/session/session.go:1993 +0x95d
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      /go/tidb/session/session.go:1859 +0xdb3
  github.com/pingcap/tidb/session.(*session).Execute()
      /go/tidb/session/session.go:1513 +0x4b9
  github.com/pingcap/tidb/testkit.(*AsyncTestKit).Exec()
      /go/tidb/testkit/asynctestkit.go:142 +0x168
  github.com/pingcap/tidb/executor_test.TestCheckFailReport.func5()
      /go/tidb/executor/admin_test.go:1234 +0x6a4
  github.com/pingcap/tidb/executor_test.TestCheckFailReport()
      /go/tidb/executor/admin_test.go:1248 +0x369
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run·dwrap·21()
      /usr/local/go/src/testing/testing.go:1306 +0x47
Previous read at 0x00c001990800 by goroutine 94:
  github.com/pingcap/tidb/sessionctx/variable.(*SessionVars).GetStatusFlag()
      /go/tidb/sessionctx/variable/session.go:1475 +0x324
  github.com/pingcap/tidb/sessionctx/variable.(*SessionVars).InTxn()
      /go/tidb/sessionctx/variable/session.go:1489 +0x318
  github.com/pingcap/tidb/session.(*session).GetInfoSchema()
      /go/tidb/session/session.go:3377 +0x2ea
  github.com/pingcap/tidb/executor.(*dataReaderBuilder).buildTableReaderBase()
      /go/tidb/executor/builder.go:4027 +0x393
  github.com/pingcap/tidb/executor.(*dataReaderBuilder).buildTableReaderFromHandles()
      /go/tidb/executor/builder.go:4056 +0x264
  github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).buildTableReader()
      /go/tidb/executor/distsql.go:672 +0xa7c
  github.com/pingcap/tidb/executor.(*tableWorker).executeTask()
      /go/tidb/executor/distsql.go:1272 +0x95
  github.com/pingcap/tidb/executor.(*tableWorker).pickAndExecTask()
      /go/tidb/executor/distsql.go:1018 +0x28b
  github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).startTableWorker.func1()
      /go/tidb/executor/distsql.go:645 +0xe4
Goroutine 59 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:1306 +0x726
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:1598 +0x99
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.runTests()
      /usr/local/go/src/testing/testing.go:1596 +0x7ca
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:1504 +0x9d1
  github.com/pingcap/tidb/testkit/testmain.(*testingM).Run()
      /go/tidb/testkit/testmain/wrapper.go:28 +0x42
  go.uber.org/goleak.VerifyTestMain()
      /home/prow/go/pkg/mod/go.uber.org/goleak@v1.1.12/testmain.go:53 +0x59
  github.com/pingcap/tidb/executor_test.TestMain()
      /go/tidb/executor/main_test.go:64 +0x785
  main.main()
      _testmain.go:955 +0x264
Goroutine 94 (running) created at:
  github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).startTableWorker()
      /go/tidb/executor/distsql.go:643 +0xe8
  github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).startWorkers()
      /go/tidb/executor/distsql.go:504 +0x119
  github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).Next()
      /go/tidb/executor/distsql.go:716 +0x10d
  github.com/pingcap/tidb/executor.Next()
      /go/tidb/executor/executor.go:286 +0x58f
  github.com/pingcap/tidb/executor.(*CheckTableExec).checkIndexHandle()
      /go/tidb/executor/executor.go:728 +0x20a
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2.1()
      /go/tidb/executor/executor.go:786 +0xbd
  github.com/pingcap/tidb/util.WithRecovery()
      /go/tidb/util/misc.go:100 +0x77
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2()
      /go/tidb/executor/executor.go:785 +0x14b
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next·dwrap·42()
      /go/tidb/executor/executor.go:791 +0x47
==================
==================
WARNING: DATA RACE
Write at 0x00c001990898 by goroutine 59:
  github.com/pingcap/tidb/executor.ResetContextOfStmt()
      /go/tidb/executor/executor.go:1882 +0x2c1e
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      /go/tidb/session/session.go:1810 +0x3c4
  github.com/pingcap/tidb/session.(*session).Execute()
      /go/tidb/session/session.go:1513 +0x4b9
  github.com/pingcap/tidb/testkit.(*AsyncTestKit).Exec()
      /go/tidb/testkit/asynctestkit.go:142 +0x168
  github.com/pingcap/tidb/testkit.(*AsyncTestKit).MustExec()
      /go/tidb/testkit/asynctestkit.go:174 +0xb7
  github.com/pingcap/tidb/executor_test.(*inconsistencyTestKit).rebuild()
      /go/tidb/executor/admin_test.go:989 +0xa4
  github.com/pingcap/tidb/executor_test.TestCheckFailReport.func5·dwrap·3()
      /go/tidb/executor/admin_test.go:1224 +0x39
  github.com/pingcap/tidb/executor_test.TestCheckFailReport.func5()
      /go/tidb/executor/admin_test.go:1248 +0xb5f
  github.com/pingcap/tidb/executor_test.TestCheckFailReport()
      /go/tidb/executor/admin_test.go:1248 +0x369
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run·dwrap·21()
      /usr/local/go/src/testing/testing.go:1306 +0x47
Previous read at 0x00c001990898 by goroutine 94:
  github.com/pingcap/tidb/executor.(*tableWorker).compareData()
      /go/tidb/executor/distsql.go:1216 +0xc1e
  github.com/pingcap/tidb/executor.(*tableWorker).executeTask()
      /go/tidb/executor/distsql.go:1280 +0x524
  github.com/pingcap/tidb/executor.(*tableWorker).pickAndExecTask()
      /go/tidb/executor/distsql.go:1018 +0x28b
  github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).startTableWorker.func1()
      /go/tidb/executor/distsql.go:645 +0xe4
Goroutine 59 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:1306 +0x726
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:1598 +0x99
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.runTests()
      /usr/local/go/src/testing/testing.go:1596 +0x7ca
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:1504 +0x9d1
  github.com/pingcap/tidb/testkit/testmain.(*testingM).Run()
      /go/tidb/testkit/testmain/wrapper.go:28 +0x42
  go.uber.org/goleak.VerifyTestMain()
      /home/prow/go/pkg/mod/go.uber.org/goleak@v1.1.12/testmain.go:53 +0x59
  github.com/pingcap/tidb/executor_test.TestMain()
      /go/tidb/executor/main_test.go:64 +0x785
  main.main()
      _testmain.go:955 +0x264
Goroutine 94 (running) created at:
  github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).startTableWorker()
      /go/tidb/executor/distsql.go:643 +0xe8
  github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).startWorkers()
      /go/tidb/executor/distsql.go:504 +0x119
  github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).Next()
      /go/tidb/executor/distsql.go:716 +0x10d
  github.com/pingcap/tidb/executor.Next()
      /go/tidb/executor/executor.go:286 +0x58f
  github.com/pingcap/tidb/executor.(*CheckTableExec).checkIndexHandle()
      /go/tidb/executor/executor.go:728 +0x20a
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2.1()
      /go/tidb/executor/executor.go:786 +0xbd
  github.com/pingcap/tidb/util.WithRecovery()
      /go/tidb/util/misc.go:100 +0x77
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2()
      /go/tidb/executor/executor.go:785 +0x14b
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next·dwrap·42()
      /go/tidb/executor/executor.go:791 +0x47
==================

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)
@hawkingrei hawkingrei added the type/bug The issue is confirmed as a bug. label Feb 12, 2022
@hawkingrei hawkingrei mentioned this issue Feb 12, 2022
Merged
12 tasks
@hawkingrei hawkingrei added component/executor affects-5.4 This bug affects the 5.4.x(LTS) versions. severity/major and removed component/executor labels Feb 12, 2022
@ti-chi-bot ti-chi-bot added may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. labels Feb 12, 2022
@hawkingrei hawkingrei added affects-5.3 This bug affects 5.3.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.0 This bug affects 5.0.x versions. affects-5.1 This bug affects 5.1.x versions. and removed may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. labels Feb 12, 2022
@hawkingrei
Copy link
Member Author 

==================
WARNING: DATA RACE
Read at 0x00c003341430 by goroutine 119:
  github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).Close()
      /go/tidb/executor/distsql.go:690 +0xd6
  github.com/pingcap/tidb/executor.(*CheckTableExec).Close()
      /go/tidb/executor/executor.go:698 +0xac
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor.func1()
      /go/tidb/executor/adapter.go:617 +0x48
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor()
      /go/tidb/executor/adapter.go:637 +0x708
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
      /go/tidb/executor/adapter.go:490 +0x29d
  github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
      /go/tidb/executor/adapter.go:439 +0xc0c
  github.com/pingcap/tidb/session.runStmt()
      /go/tidb/session/session.go:1982 +0x70b
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      /go/tidb/session/session.go:1859 +0xdb3
  github.com/pingcap/tidb/session.(*session).Execute()
      /go/tidb/session/session.go:1513 +0x4b9
  github.com/pingcap/tidb/testkit.(*AsyncTestKit).Exec()
      /go/tidb/testkit/asynctestkit.go:142 +0x168
  github.com/pingcap/tidb/executor_test.TestCheckFailReport.func5()
      /go/tidb/executor/admin_test.go:1234 +0x6a4
  github.com/pingcap/tidb/executor_test.TestCheckFailReport()
      /go/tidb/executor/admin_test.go:1248 +0x369
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run·dwrap·21()
      /usr/local/go/src/testing/testing.go:1306 +0x47
Previous write at 0x00c003341430 by goroutine 65:
  github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).startWorkers()
      /go/tidb/executor/distsql.go:499 +0x7a
  github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).Next()
      /go/tidb/executor/distsql.go:716 +0x10d
  github.com/pingcap/tidb/executor.Next()
      /go/tidb/executor/executor.go:286 +0x58f
  github.com/pingcap/tidb/executor.(*CheckTableExec).checkIndexHandle()
      /go/tidb/executor/executor.go:728 +0x20a
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2.1()
      /go/tidb/executor/executor.go:786 +0xbd
  github.com/pingcap/tidb/util.WithRecovery()
      /go/tidb/util/misc.go:100 +0x77
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2()
      /go/tidb/executor/executor.go:785 +0x14b
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next·dwrap·42()
      /go/tidb/executor/executor.go:791 +0x47
Goroutine 119 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:1306 +0x726
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:1598 +0x99
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.runTests()
      /usr/local/go/src/testing/testing.go:1596 +0x7ca
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:1504 +0x9d1
  github.com/pingcap/tidb/testkit/testmain.(*testingM).Run()
      /go/tidb/testkit/testmain/wrapper.go:28 +0x42
  go.uber.org/goleak.VerifyTestMain()
      /home/prow/go/pkg/mod/go.uber.org/goleak@v1.1.12/testmain.go:53 +0x59
  github.com/pingcap/tidb/executor_test.TestMain()
      /go/tidb/executor/main_test.go:64 +0x785
  main.main()
      _testmain.go:955 +0x264
Goroutine 65 (finished) created at:
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next()
      /go/tidb/executor/executor.go:783 +0x8cb
  github.com/pingcap/tidb/executor.Next()
      /go/tidb/executor/executor.go:286 +0x58f
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor()
      /go/tidb/executor/adapter.go:635 +0x6e9
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
      /go/tidb/executor/adapter.go:490 +0x29d
  github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
      /go/tidb/executor/adapter.go:439 +0xc0c
  github.com/pingcap/tidb/session.runStmt()
      /go/tidb/session/session.go:1982 +0x70b
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      /go/tidb/session/session.go:1859 +0xdb3
  github.com/pingcap/tidb/session.(*session).Execute()
      /go/tidb/session/session.go:1513 +0x4b9
  github.com/pingcap/tidb/testkit.(*AsyncTestKit).Exec()
      /go/tidb/testkit/asynctestkit.go:142 +0x168
  github.com/pingcap/tidb/executor_test.TestCheckFailReport.func5()
      /go/tidb/executor/admin_test.go:1234 +0x6a4
  github.com/pingcap/tidb/executor_test.TestCheckFailReport()
      /go/tidb/executor/admin_test.go:1248 +0x369
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run·dwrap·21()
      /usr/local/go/src/testing/testing.go:1306 +0x47
==================
==================
WARNING: DATA RACE
Write at 0x00c003b41250 by goroutine 119:
  sync/atomic.CompareAndSwapInt32()
      /usr/local/go/src/runtime/race_amd64.s:334 +0xb
  sync/atomic.CompareAndSwapInt32()
      <autogenerated>:1 +0x1e
  context.(*cancelCtx).cancel()
      /usr/local/go/src/context/context.go:401 +0x84
  context.WithCancel.func1()
      /usr/local/go/src/context/context.go:238 +0x4f
  github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).Close()
      /go/tidb/executor/distsql.go:691 +0x101
  github.com/pingcap/tidb/executor.(*CheckTableExec).Close()
      /go/tidb/executor/executor.go:698 +0xac
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor.func1()
      /go/tidb/executor/adapter.go:617 +0x48
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor()
      /go/tidb/executor/adapter.go:637 +0x708
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
      /go/tidb/executor/adapter.go:490 +0x29d
  github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
      /go/tidb/executor/adapter.go:439 +0xc0c
  github.com/pingcap/tidb/session.runStmt()
      /go/tidb/session/session.go:1982 +0x70b
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      /go/tidb/session/session.go:1859 +0xdb3
  github.com/pingcap/tidb/session.(*session).Execute()
      /go/tidb/session/session.go:1513 +0x4b9
  github.com/pingcap/tidb/testkit.(*AsyncTestKit).Exec()
      /go/tidb/testkit/asynctestkit.go:142 +0x168
  github.com/pingcap/tidb/executor_test.TestCheckFailReport.func5()
      /go/tidb/executor/admin_test.go:1234 +0x6a4
  github.com/pingcap/tidb/executor_test.TestCheckFailReport()
      /go/tidb/executor/admin_test.go:1248 +0x369
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run·dwrap·21()
      /usr/local/go/src/testing/testing.go:1306 +0x47
Previous write at 0x00c003b41250 by goroutine 65:
  context.WithCancel()
      /usr/local/go/src/context/context.go:236 +0xa4
  github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).startWorkers()
      /go/tidb/executor/distsql.go:498 +0x50
  github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).Next()
      /go/tidb/executor/distsql.go:716 +0x10d
  github.com/pingcap/tidb/executor.Next()
      /go/tidb/executor/executor.go:286 +0x58f
  github.com/pingcap/tidb/executor.(*CheckTableExec).checkIndexHandle()
      /go/tidb/executor/executor.go:728 +0x20a
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2.1()
      /go/tidb/executor/executor.go:786 +0xbd
  github.com/pingcap/tidb/util.WithRecovery()
      /go/tidb/util/misc.go:100 +0x77
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2()
      /go/tidb/executor/executor.go:785 +0x14b
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next·dwrap·42()
      /go/tidb/executor/executor.go:791 +0x47
Goroutine 119 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:1306 +0x726
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:1598 +0x99
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.runTests()
      /usr/local/go/src/testing/testing.go:1596 +0x7ca
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:1504 +0x9d1
  github.com/pingcap/tidb/testkit/testmain.(*testingM).Run()
      /go/tidb/testkit/testmain/wrapper.go:28 +0x42
  go.uber.org/goleak.VerifyTestMain()
      /home/prow/go/pkg/mod/go.uber.org/goleak@v1.1.12/testmain.go:53 +0x59
  github.com/pingcap/tidb/executor_test.TestMain()
      /go/tidb/executor/main_test.go:64 +0x785
  main.main()
      _testmain.go:955 +0x264
Goroutine 65 (finished) created at:
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next()
      /go/tidb/executor/executor.go:783 +0x8cb
  github.com/pingcap/tidb/executor.Next()
      /go/tidb/executor/executor.go:286 +0x58f
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor()
      /go/tidb/executor/adapter.go:635 +0x6e9
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
      /go/tidb/executor/adapter.go:490 +0x29d
  github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
      /go/tidb/executor/adapter.go:439 +0xc0c
  github.com/pingcap/tidb/session.runStmt()
      /go/tidb/session/session.go:1982 +0x70b
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      /go/tidb/session/session.go:1859 +0xdb3
  github.com/pingcap/tidb/session.(*session).Execute()
      /go/tidb/session/session.go:1513 +0x4b9
  github.com/pingcap/tidb/testkit.(*AsyncTestKit).Exec()
      /go/tidb/testkit/asynctestkit.go:142 +0x168
  github.com/pingcap/tidb/executor_test.TestCheckFailReport.func5()
      /go/tidb/executor/admin_test.go:1234 +0x6a4
  github.com/pingcap/tidb/executor_test.TestCheckFailReport()
      /go/tidb/executor/admin_test.go:1248 +0x369
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run·dwrap·21()
      /usr/local/go/src/testing/testing.go:1306 +0x47
==================
==================
WARNING: DATA RACE
Write at 0x00c003341370 by goroutine 119:
  github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).Close()
      /go/tidb/executor/distsql.go:704 +0x284
  github.com/pingcap/tidb/executor.(*CheckTableExec).Close()
      /go/tidb/executor/executor.go:698 +0xac
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor.func1()
      /go/tidb/executor/adapter.go:617 +0x48
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor()
      /go/tidb/executor/adapter.go:637 +0x708
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
      /go/tidb/executor/adapter.go:490 +0x29d
  github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
      /go/tidb/executor/adapter.go:439 +0xc0c
  github.com/pingcap/tidb/session.runStmt()
      /go/tidb/session/session.go:1982 +0x70b
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      /go/tidb/session/session.go:1859 +0xdb3
  github.com/pingcap/tidb/session.(*session).Execute()
      /go/tidb/session/session.go:1513 +0x4b9
  github.com/pingcap/tidb/testkit.(*AsyncTestKit).Exec()
      /go/tidb/testkit/asynctestkit.go:142 +0x168
  github.com/pingcap/tidb/executor_test.TestCheckFailReport.func5()
      /go/tidb/executor/admin_test.go:1234 +0x6a4
  github.com/pingcap/tidb/executor_test.TestCheckFailReport()
      /go/tidb/executor/admin_test.go:1248 +0x369
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run·dwrap·21()
      /usr/local/go/src/testing/testing.go:1306 +0x47
Previous write at 0x00c003341370 by goroutine 65:
  github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).getResultTask()
      /go/tidb/executor/distsql.go:756 +0x1d9
  github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).Next()
      /go/tidb/executor/distsql.go:722 +0x18a
  github.com/pingcap/tidb/executor.Next()
      /go/tidb/executor/executor.go:286 +0x58f
  github.com/pingcap/tidb/executor.(*CheckTableExec).checkIndexHandle()
      /go/tidb/executor/executor.go:728 +0x20a
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2.1()
      /go/tidb/executor/executor.go:786 +0xbd
  github.com/pingcap/tidb/util.WithRecovery()
      /go/tidb/util/misc.go:100 +0x77
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2()
      /go/tidb/executor/executor.go:785 +0x14b
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next·dwrap·42()
      /go/tidb/executor/executor.go:791 +0x47
Goroutine 119 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:1306 +0x726
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:1598 +0x99
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.runTests()
      /usr/local/go/src/testing/testing.go:1596 +0x7ca
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:1504 +0x9d1
  github.com/pingcap/tidb/testkit/testmain.(*testingM).Run()
      /go/tidb/testkit/testmain/wrapper.go:28 +0x42
  go.uber.org/goleak.VerifyTestMain()
      /home/prow/go/pkg/mod/go.uber.org/goleak@v1.1.12/testmain.go:53 +0x59
  github.com/pingcap/tidb/executor_test.TestMain()
      /go/tidb/executor/main_test.go:64 +0x785
  main.main()
      _testmain.go:955 +0x264
Goroutine 65 (finished) created at:
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next()
      /go/tidb/executor/executor.go:783 +0x8cb
  github.com/pingcap/tidb/executor.Next()
      /go/tidb/executor/executor.go:286 +0x58f
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor()
      /go/tidb/executor/adapter.go:635 +0x6e9
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
      /go/tidb/executor/adapter.go:490 +0x29d
  github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
      /go/tidb/executor/adapter.go:439 +0xc0c
  github.com/pingcap/tidb/session.runStmt()
      /go/tidb/session/session.go:1982 +0x70b
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      /go/tidb/session/session.go:1859 +0xdb3
  github.com/pingcap/tidb/session.(*session).Execute()
      /go/tidb/session/session.go:1513 +0x4b9
  github.com/pingcap/tidb/testkit.(*AsyncTestKit).Exec()
      /go/tidb/testkit/asynctestkit.go:142 +0x168
  github.com/pingcap/tidb/executor_test.TestCheckFailReport.func5()
      /go/tidb/executor/admin_test.go:1234 +0x6a4
  github.com/pingcap/tidb/executor_test.TestCheckFailReport()
      /go/tidb/executor/admin_test.go:1248 +0x369
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run·dwrap·21()
      /usr/local/go/src/testing/testing.go:1306 +0x47
==================

@hawkingrei hawkingrei mentioned this issue Feb 16, 2022
Closed
ti-chi-bot pushed a commit that referenced this issue Feb 22, 2022
@hawkingrei
executor: tiny refactor code to improve CheckTableExec (#32295)
f60a589 
close #32294
This was referenced Feb 22, 2022
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.0 This bug affects 5.0.x versions. affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. component/test severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor: tiny refactor code to improve CheckTableExec hawkingrei/tidb
3 participants
@tiancaiamao @hawkingrei @ti-chi-bot