Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: tiny refactor code to improve CheckTableExec #32295

Merged
merged 5 commits into from
Feb 22, 2022
Merged

executor: tiny refactor code to improve CheckTableExec #32295

merged 5 commits into from
Feb 22, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Feb 12, 2022 •
edited
Loading

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What problem does this PR solve?

Issue Number: close #32294

Problem Summary:
1、When Close CheckTableExec, it will stop all the goroutine.
2、When checkIndexHandle meet error. it will stop all the goroutine created by CheckTableExec.
3、no wait for WaitGroup for a long time.
4、fix data race.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
    use old test cases.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 12, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • guo-shaoge
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 12, 2022
@hawkingrei
Copy link
Member Author

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Feb 12, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/eacac3681c4c382d2aa5ee790b2cbc5a8f0f0141

@hawkingrei
Copy link
Member Author

/run-check_dev

@hawkingrei hawkingrei force-pushed the close_exitch_checktableexec branch 2 times, most recently from 926ac5f to 5c1d48a Compare February 15, 2022 09:03
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 15, 2022
@hawkingrei hawkingrei changed the title executor: close the exitCh in the CheckTableExec executor: improve CheckTableExec Feb 15, 2022
@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei hawkingrei changed the title executor: improve CheckTableExec executor: tiny refactor code to improve CheckTableExec Feb 16, 2022
@hawkingrei
Copy link
Member Author

/run-mysql-test

zimulala
zimulala reviewed Feb 16, 2022
View reviewed changes
executor/executor.go Show resolved Hide resolved
executor/executor.go Show resolved Hide resolved
@hawkingrei
Copy link
Member Author

/run-mysql-test

@tiancaiamao tiancaiamao self-requested a review February 18, 2022 06:55
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 22, 2022
@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei
Copy link
Member Author

/run-unit-test

@wshwsh12
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1895b0e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2022
@hawkingrei
Copy link
Member Author

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit f60a589 into pingcap:master Feb 22, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 22, 2022
@hawkingrei @ti-srebot
cherry pick pingcap#32295 to release-5.0
fb98f25 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 22, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #32527

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 22, 2022
@hawkingrei @ti-srebot
cherry pick pingcap#32295 to release-5.1
3fecde6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 22, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #32528

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 22, 2022
@hawkingrei @ti-srebot
cherry pick pingcap#32295 to release-5.2
11f5db7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 22, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #32529

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 22, 2022
@hawkingrei @ti-srebot
cherry pick pingcap#32295 to release-5.3
b706582 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 22, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #32530

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 22, 2022
@hawkingrei @ti-srebot
cherry pick pingcap#32295 to release-5.4
477e576 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 22, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #32531

@hawkingrei hawkingrei deleted the close_exitch_checktableexec branch February 23, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@zimulala zimulala Awaiting requested review from zimulala

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DATA RACE in the TestCheckFailReport
8 participants
@hawkingrei @ti-chi-bot @sre-bot @wshwsh12 @ti-srebot @tiancaiamao @zimulala @guo-shaoge