Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression by pr/33861 #34502

Open
tiancaiamao opened this issue May 9, 2022 · 4 comments
Open

Performance regression by pr/33861 #34502

tiancaiamao opened this issue May 9, 2022 · 4 comments
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@tiancaiamao
Copy link
Contributor

Enhancement

Found by #25754
See http://www.zenlife.tk:18081/alloc

image

image

image

@tiancaiamao tiancaiamao added the type/enhancement The issue or PR belongs to an enhancement. label May 9, 2022
@tiancaiamao
Copy link
Contributor Author

cd session
go test -run TestXX -bench BenchmarkExplainTableLookup -benchmem

Before #33861

BenchmarkExplainTableLookup-16    	   42543	     27101 ns/op	   15505 B/op	     198 allocs/op

and After

BenchmarkExplainTableLookup-16    	   38823	     29272 ns/op	   16636 B/op	     219 allocs/op

You can also use some other function like BenchmarkBatchPointGet BenchmarkPointGet

@mornyx
Copy link
Contributor

mornyx commented May 11, 2022

Should be the same as #34525.

image

The green part should be covered by #34558, but the blue part is still not clear.

Please help confirm why the stmtsummary module is taking a lot of memory and whether this is expected. cc @crazycs520

@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented May 13, 2022

@mornyx As far as I know, stmtsummary is always a large part of the object allocating...
It's not a regression, it's something just always there (maybe we should optimize it)

@mornyx
Copy link
Contributor

mornyx commented May 13, 2022

As far as I know, stmtsummary is always a large part of the object allocating... It's not a regression, it's something just always there (maybe we should optimize it)

Got it, thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants