-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
topsql: fix issue of topsql failed catch the running SQL when topsql is enabled in execution #33861
Conversation
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
/merge |
2 similar comments
/merge |
/merge |
/run-all-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3da532e
|
/merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A green approval on behalf of the bot.
/merge |
TiDB MergeCI notify🔴 Bad News! New failing [2] after this pr merged.
|
What problem does this PR solve?
Issue Number: close #33859
Problem Summary:
Fix issue of topsql failed catch the running SQL when topsql is enabled in execution
What is changed and how it works?
Always attach the SQL and Plan information whether TopSQL is enabled.
Benchmark Test
Sysbench test
Machine: AWS c4.4xlarge, 16 cpu core, 32G memory.
Topology: 1TiDB, 1TiKV, 1*PD
Check List
Tests
Create table
t1
and insert into 10000000 rows data.Mock some normal OLTP load by loadgen:
TiDB:
TiKV
Side effects
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.