Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitoring go runtime by runtime/metrics package #35016

Closed
zyguan opened this issue May 29, 2022 · 0 comments · Fixed by #35017
Closed

Monitoring go runtime by runtime/metrics package #35016

zyguan opened this issue May 29, 2022 · 0 comments · Fixed by #35017
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@zyguan
Copy link
Contributor

zyguan commented May 29, 2022

Enhancement

runtime/metrics has been introduced to stdlib since go1.16, and we are also allowed to monitor sched latency after go1.17. However, the prometheus client that tidb used is v1.11.0 currently, which still gathers runtime metrics from runtime.MemStats. To integrate runtime/metrics, we can simply bump prometheus client to v1.12.2 and use the new go collector.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

metrics: bump prometheus client and use new go collector zyguan/tidb
1 participant
@zyguan